Preview Cleanup + Seperating Components #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR seperates out feature components from the screen file. It's actually a bit cumbersome to leverage previews when there are a BUNCH of previews in the same file. Also discoverability suffers, so I moved a bunch of things out into their own component files. This also makes it easy to see the various states of each component. It also isolates the screen files to only have previews at the screen level.
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
📸 Snapshot Test5 modified, 47 added, 25 removed, 15 unchanged
🛸 Powered by Emerge Tools |
rbro112
reviewed
Aug 16, 2024
android/app/src/main/java/com/emergetools/hackernews/ui/preview/AppStoreSnapshot.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR seperates out feature components from the screen file. It's actually a bit cumbersome to leverage previews when there are a BUNCH of previews in the same file. Also discoverability suffers, so I moved a bunch of things out into their own component files. This also makes it easy to see the various states of each component.
It also isolates the screen files to only have previews at the screen level.