Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding More Feed Types #116

Merged
merged 4 commits into from
Aug 14, 2024
Merged

Adding More Feed Types #116

merged 4 commits into from
Aug 14, 2024

Conversation

Rahkeen
Copy link
Collaborator

@Rahkeen Rahkeen commented Aug 13, 2024

I updated the Feed Header design to look nicer and work better with more feeds. I'm using saket's squiggly span decoration because its fun but also fits the theme nicely.

Then I just added more feeds like best, show, and ask. I might also add jobs.

Copy link
Collaborator Author

Rahkeen commented Aug 13, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Rahkeen and the rest of your teammates on Graphite Graphite

@Rahkeen Rahkeen mentioned this pull request Aug 13, 2024
@Rahkeen Rahkeen requested a review from rbro112 August 13, 2024 23:35
@Rahkeen Rahkeen marked this pull request as ready for review August 13, 2024 23:35
@Rahkeen Rahkeen changed the base branch from domain-cleanup to graphite-base/116 August 14, 2024 00:07
@Rahkeen Rahkeen force-pushed the graphite-base/116 branch from 520b326 to d7a3c7a Compare August 14, 2024 00:07
@Rahkeen Rahkeen changed the base branch from graphite-base/116 to main August 14, 2024 00:07
I updated the Feed Header design to look nicer and work better with more feeds. I'm using saket's squiggly span decoration because its fun but also fits the theme nicely.

Then I just added more feeds like best, show, and ask. I might also add jobs.
Copy link

emerge-tools bot commented Aug 14, 2024

📸 Snapshot Test

8 modified, 2 added, 2 removed, 32 unchanged

Name Version Added Removed Modified Unchanged Errored Approval
Hacker News
com.emergetools.hackernews.debug
1.0-beta01 (3) 2 2 8 32 0 ✅ Approved

🛸 Powered by Emerge Tools

Copy link
Collaborator Author

Rahkeen commented Aug 14, 2024

Merge activity

  • Aug 14, 2:24 PM EDT: @Rahkeen started a stack merge that includes this pull request via Graphite.

@Rahkeen Rahkeen merged commit 8fd07d3 into main Aug 14, 2024
5 of 6 checks passed
Copy link
Collaborator Author

Rahkeen commented Aug 14, 2024

Merge activity

  • Aug 14, 2:24 PM EDT: @Rahkeen merged this pull request with Graphite.
  • Aug 14, 2:24 PM EDT: @Rahkeen started a stack merge that includes this pull request via Graphite.

@Rahkeen Rahkeen deleted the more-feed-types branch August 14, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants