Adding About Info to Settings #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We discussed adding some attribution and links to an About section. I just added social links and a link to the emerge tools landing page. I also added a placeholder for a feedback form, which we can fill in once we have a notion page or similar thing setup. Lastly I wanted to add some fun + emerge-y branding so I created a card that has a sort of starfield animation. I built this a lil while ago and it felt fitting, can remove it if it's too extra.
2 builds increased size
Hacker News 1.0 (1)
|
| Item | Install Size Change | Download Size Change |
|---|---|---|
| 📝 unbounded.ttf | ⬆️ 384.0 kB | ⬆️ 384.0 kB |
| 📝 androidx.core.app.NavUtils | ⬆️ 24.9 kB | ⬆️ 11.3 kB |
| 🗑 io.sentry.util.IntegrationUtils | ⬇️ -18.9 kB | ⬇️ -8.6 kB |
| 🗑 io.sentry.util.LogUtils | ⬇️ -16.6 kB | ⬇️ -7.5 kB |
| 🗑 io.sentry.util.HintUtils | ⬇️ -14.9 kB | ⬇️ -6.8 kB |
View Treemap
Hacker News 1.0 (1)
com.emergetools.hackernews.debug
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬆️ 919.0 kB (2.6%)
Total download size change: ⬆️ 416.5 kB (3.39%)
Largest size changes
| Item | Install Size Change | Download Size Change |
|---|---|---|
| 📝 unbounded.ttf | ⬆️ 384.0 kB | ⬆️ 384.0 kB |
| 📝 com.emergetools.hackernews.features.settings.SettingsComponentsKt | ⬆️ 21.7 kB | ⬆️ 8.3 kB |
| com.emergetools.hackernews.features.settings.SettingsScreenKt | ⬇️ -10.0 kB | ⬇️ -4.0 kB |
| 📝 androidx.graphics.shapes.ShapesKt | ⬆️ 7.8 kB | ⬆️ 2.8 kB |
| 📝 androidx.graphics.shapes.Cubic | ⬆️ 5.0 kB | ⬆️ 1.8 kB |
View Treemap
🛸 Powered by Emerge Tools
Comment trigger: Size diff threshold of 100.00kB exceeded
📸 Snapshot Test2 modified, 5 added, 31 unchanged
🛸 Powered by Emerge Tools |
rbro112
approved these changes
Aug 7, 2024
Rahkeen
added a commit
that referenced
this pull request
Aug 8, 2024
We discussed adding some attribution and links to an About section. I just added social links and a link to the emerge tools landing page. I also added a placeholder for a feedback form, which we can fill in once we have a notion page or similar thing setup. Lastly I wanted to add some fun + emerge-y branding so I created a card that has a sort of starfield animation. I built this a lil while ago and it felt fitting, can remove it if it's too extra.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discussed adding some attribution and links to an About section. I just added social links and a link to the emerge tools landing page.
I also added a placeholder for a feedback form, which we can fill in once we have a notion page or similar thing setup.
Lastly I wanted to add some fun + emerge-y branding so I created a card that has a sort of starfield animation. I built this a lil while ago and it felt fitting, can remove it if it's too extra.