updated to specifically check for a parsed JsonNull, as that is more …

…appropriate
EmergeTools · Jul 25, 2024 · 028c427 · 028c427
1 parent fe0ab0f
commit 028c427
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/android/app/src/main/java/com/emergetools/hackernews/data/HackerNewsBaseDataSource.kt b/android/app/src/main/java/com/emergetools/hackernews/data/HackerNewsBaseDataSource.kt
@@ -4,6 +4,7 @@ import kotlinx.serialization.Serializable
 import kotlinx.serialization.json.Json
 import kotlinx.serialization.json.JsonContentPolymorphicSerializer
 import kotlinx.serialization.json.JsonElement
+import kotlinx.serialization.json.JsonNull
 import kotlinx.serialization.json.jsonObject
 import okhttp3.MediaType.Companion.toMediaType
 import okhttp3.OkHttpClient
@@ -36,8 +37,8 @@ sealed interface BaseResponse {
 
 object BaseResponseSerializer : JsonContentPolymorphicSerializer<BaseResponse>(BaseResponse::class) {
   override fun selectDeserializer(element: JsonElement) = when {
-    "id" in element.jsonObject -> BaseResponse.Item.serializer()
-    else -> BaseResponse.NullResponse.serializer()
+    element is JsonNull -> BaseResponse.NullResponse.serializer()
+    else -> BaseResponse.Item.serializer()
   }
 }