lightningd: don't force state if gossipd gives us an unexpected channel_update. #7058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdecker
force-pushed
the
fix-lost-db-gossip-crash
branch
2 times, most recently
from
02909df to
9cfc3a3
Compare
|
The new warning is being hit in several places: It being |
cdecker
force-pushed
the
fix-lost-db-gossip-crash
branch
3 times, most recently
from
33af030 to
8e04c66
Compare
|
Removing from the milestone as it still fails with a |
rustyrussell
force-pushed
the
fix-lost-db-gossip-crash
branch
from
8e04c66 to
a1377c8
Compare
…el_update. This was triggered by the recover plugin tests (not yet merged!) and causes a crash because we don't have signatures yet. It can only happen if we lost our database, but at least don't crash! Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
force-pushed
the
fix-lost-db-gossip-crash
branch
from
a1377c8 to
62bc22d
Compare
|
This was overzealous: fixed and tested. Since it's an actual crash, I'll apply once CI is happy... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was triggered by the recover plugin tests (not yet merged!) and causes a crash because we don't have signatures yet. It can only happen if we lost our database, but at least don't crash!
Fixes the crash in #6853