Update to wally 1.0.0 #6882
Closed
Update to wally 1.0.0 #6882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgriffiths
force-pushed
the
update_to_wally_1_0
branch
3 times, most recently
from
43e726f to
de10c6b
Compare
jgriffiths
force-pushed
the
update_to_wally_1_0
branch
from
de10c6b to
8c47876
Compare
Rename the offending functions from wally_foo to cln_wally_foo. For the sake of a minimal diff, only calls which conflict with wally v1.0.0 have been changed. However it is bad form to use the wally_ function namespace; the remaining such calls should also be renamed. Changelog-None Signed-off-by: Jon Griffiths <[email protected]>
Also removes incorrect/redundant configure flags when building. Changelog-Changed: Update libwally to 1.0.0 Signed-off-by: Jon Griffiths <[email protected]>
As of wally v1.0.0, Elements/Liquid support is enabled and part of the library ABI by default. Changelog-None Signed-off-by: Jon Griffiths <[email protected]>
Wally release builds are significantly faster than debug builds. Plus we pass down our build flags to libsecp, which means release builds have been disabling the asm optimisations for both libraries. Changelog-Changed: Enable optimizations for libwally/libsecp256k1-zkp Signed-off-by: Jon Griffiths <[email protected]>
Changelog-None Signed-off-by: Jon Griffiths <[email protected]>
Changelog-None Signed-off-by: Jon Griffiths <[email protected]>
Changelog-None Signed-off-by: Jon Griffiths <[email protected]>
Input cloning has not been exposed yet; I'll add that to wally in a future release. Changelog-None Signed-off-by: Jon Griffiths <[email protected]>
jgriffiths
force-pushed
the
update_to_wally_1_0
branch
from
8c47876 to
153a38c
Compare
|
Looks like this was merged? Closing... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update wally to v1.0.0.
Removed the witness reworking until I have time to figure out how the tal stuff works.
I don't think the CI failure is my fault, would be good to have confirmation of that.