fix cancellation tokens

ElectNewt · Nov 19, 2024 · a83d242 · a83d242
1 parent 471077d
commit a83d242
Showing 1 changed file with 14 additions and 9 deletions.
diff --git a/src/Services/Orders/Distribt.Services.Orders/Services/CreateOrderService.cs b/src/Services/Orders/Distribt.Services.Orders/Services/CreateOrderService.cs
@@ -36,10 +36,10 @@ public async Task<Result<CreateOrderResponse>> Execute(CreateOrderRequest create
             .Async()
             //On a real scenario:
             //validate orders
-            //validate fraud check
+            .Bind(x=> ValidateFraudCheck(x, cancellationToken))
             .Bind(x => SaveOrder(x, cancellationToken))
-            .Then(x => MapToOrderResponse(x, cancellationToken)
-                .Bind(or => PublishDomainEvent(or, cancellationToken)))
+            .Then(x => MapToOrderResponse(x)
+                .Bind(PublishDomainEvent))
             .Map(x => new CreateOrderResponse(x.Id, $"order/getorderstatus/{x.Id}"));
     }
 
@@ -60,23 +60,28 @@ private async Task<Result<OrderDetails>> SaveOrder(OrderDetails orderDetails, Ca
         return orderDetails;
     }
 
-    private async Task<Result<OrderResponse>> MapToOrderResponse(OrderDetails orderDetails,
-        CancellationToken cancellationToken)
+    private async Task<Result<OrderResponse>> MapToOrderResponse(OrderDetails orderDetails)
     {
         var products = await orderDetails.Products
             .SelectAsync(async p => new ProductQuantityName(p.ProductId, p.Quantity,
-                await _productNameService.GetProductName(p.ProductId, cancellationToken)));
+                await _productNameService.GetProductName(p.ProductId)));
 
 
         OrderResponse orderResponse = new OrderResponse(orderDetails.Id, orderDetails.Status.ToString(),
             orderDetails.Delivery, orderDetails.PaymentInformation, products.ToList());
         return orderResponse;
     }
 
-    private async Task<Result<Guid>> PublishDomainEvent(OrderResponse orderResponse,
-        CancellationToken cancellationToken)
+    private async Task<Result<Guid>> PublishDomainEvent(OrderResponse orderResponse)
     {
-        await _domainMessagePublisher.Publish(orderResponse, routingKey: "order", cancellationToken: cancellationToken);
+        await _domainMessagePublisher.Publish(orderResponse, routingKey: "order");
         return orderResponse.OrderId;
     }
+
+    private async Task<Result<OrderDetails>> ValidateFraudCheck(OrderDetails orderDetails,
+        CancellationToken cancellationToken)
+    {
+        //Simulation of fraud check validation
+        return orderDetails;
+    }
 }