[WIP] [SourceField] Fix undefindex source field option position #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
PierreGauthier
commented
Jan 9, 2025
PierreGauthier
commented
| Q | A |
|---|---|
| Branch? | master for features / current stable version branch for bug fixes |
| Tickets | #... |
| License | OSL-3.0 |
botisSmile
reviewed
Jan 9, 2025
| @@ -256,7 +256,7 @@ private function insertOptions() | |||
| 'source_field_id' => (int) $optionData['source_field_id'], | |||
| 'code' => $expBuilder->literal($optionData['code']), | |||
| 'default_label' => $expBuilder->literal($optionData['defaultLabel']), | |||
| 'position' => $optionData['position'] ? (int) $optionData['position'] : 'NULL', | |||
| 'position' => isset($optionData['position']) ? (int) $optionData['position'] : 'NULL', | |||
There was a problem hiding this comment.
il faut peut-être ajouter un test pour couvrir ce cas ?
PierreGauthier
force-pushed
the
fix-sourceFieldOptionPosition
branch
from
51f618c to
4f14c13
Compare
PierreGauthier
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.