Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#1327860): joinUrlPath function to avoid error when one part of th… #223

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

botisSmile
Copy link
Contributor

…e url is null

Q A
Branch? master for features / current stable version branch for bug fixes
Tickets #...
License OSL-3.0

@botisSmile botisSmile force-pushed the fix-1327860-NullImageBreakGrids branch from 9ffd59d to ea16d2e Compare January 27, 2025 11:20
@botisSmile botisSmile changed the title fix(1327860): joinUrlPath function to avoid error when one part of th… fix(#1327860): joinUrlPath function to avoid error when one part of th… Jan 27, 2025
Copy link

Frontend Shared Coverage of this branch

File Coverage
All files 74%
src/hooks/index.ts 0%
src/hooks/useSchemaLoader.ts 93%
src/services/api.ts 71%
src/services/breadcrumb.ts 94%
src/services/catalog.ts 80%
src/services/category.ts 88%
src/services/explain.ts 92%
src/services/fetch.ts 97%
src/services/field.ts 97%
src/services/form.ts 5%
src/services/format.ts 73%
src/services/hoc.ts 83%
src/services/hydra.ts 65%
src/services/index.ts 0%
src/services/log.ts 94%
src/services/parser.ts 77%
src/services/rules.ts 87%
src/services/storage.ts 75%
src/services/table.ts 80%
src/services/url.ts 98%

Minimum allowed coverage is 1%

Generated by 🐒 cobertura-action against ea16d2e

Copy link

Frontend Components Coverage of this branch

File Coverage
All files NaN%

Minimum allowed coverage is 1%

Generated by 🐒 cobertura-action against ea16d2e

expect(joinUrlPath('base_url', null)).toEqual('base_url/')
expect(joinUrlPath('base_url', null, 'media_catalog')).toEqual(
'base_url//media_catalog'
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tu ne voudrais pas plutôt avoir 'base_url/media_catalog' dans ce cas ?
(En gros ajouter un filter avant pour supprimer les éléments vide du tableau)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non car on veut montrer à l'utilisateur les parties de l'url qui seraient potentiellement vides pour l'aider à debugger, s'il voit un vide entre deux slash c'est qu'il y a un problème.

@botisSmile botisSmile merged commit 1de4b87 into 2.0.x Jan 28, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants