-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(1314737): [Boost] Add Proportional Attribute Component to the Fi… #219
feat(1314737): [Boost] Add Proportional Attribute Component to the Fi… #219
Conversation
8adebba
to
75b2228
Compare
Frontend Shared Coverage of this branch
Minimum allowed coverage is Generated by 🐒 cobertura-action against 5346e64 |
Frontend Components Coverage of this branch
Minimum allowed coverage is Generated by 🐒 cobertura-action against 5346e64 |
required={radioGroupProps.required} | ||
> | ||
{label} | ||
{infoTooltip ? <InfoTooltip title={infoTooltip} /> : null} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
si tu veux éviter le ternaire tu peux faire comme ce que tu as fait à la ligne 41:
{Boolean(infoTooltip) && <InfoTooltip title={infoTooltip} />}
display: 'flex', | ||
flexDirection: 'column', | ||
gap: theme.spacing(1), | ||
})) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
si possible mettre les styled components dans un fichier à part .styled.tsx
(cf le composant CustomTable)
après on ne le fait peut-être pas systématiquement, je ne me souviens plus ce qu'on s'était dis
'metadata.entity': 'product', | ||
}), | ||
[] | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
si ça ne change jamais, tu peux déclarer ces variables à l'extérieur du composant (et du coup sans le useMemo)
447e73e
to
58c0771
Compare
0010a19
to
41a33d9
Compare
bf4bb99
to
ca47726
Compare
ca47726
to
5346e64
Compare
…eldGuesser