Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(1314737): [Boost] Add Proportional Attribute Component to the Fi… #219

Merged

Conversation

matthias-goupil
Copy link
Contributor

…eldGuesser

Q A
Branch? master for features / current stable version branch for bug fixes
Tickets #...
License OSL-3.0

@matthias-goupil matthias-goupil marked this pull request as ready for review January 21, 2025 15:28
@matthias-goupil matthias-goupil force-pushed the feat-1314737-BoostsAddProportionnalToAttributeComponent branch from 8adebba to 75b2228 Compare January 22, 2025 15:26
@matthias-goupil matthias-goupil requested a review from tonai January 22, 2025 15:26
Copy link

github-actions bot commented Jan 22, 2025

Frontend Shared Coverage of this branch

File Coverage
All files 74%
src/hooks/index.ts 0%
src/hooks/useSchemaLoader.ts 93%
src/services/api.ts 71%
src/services/breadcrumb.ts 94%
src/services/catalog.ts 80%
src/services/category.ts 88%
src/services/explain.ts 92%
src/services/fetch.ts 97%
src/services/field.ts 97%
src/services/form.ts 5%
src/services/format.ts 73%
src/services/hoc.ts 83%
src/services/hydra.ts 64%
src/services/index.ts 0%
src/services/log.ts 94%
src/services/parser.ts 77%
src/services/rules.ts 87%
src/services/storage.ts 75%
src/services/table.ts 80%
src/services/url.ts 98%

Minimum allowed coverage is 1%

Generated by 🐒 cobertura-action against 5346e64

Copy link

github-actions bot commented Jan 22, 2025

Frontend Components Coverage of this branch

File Coverage
All files NaN%

Minimum allowed coverage is 1%

Generated by 🐒 cobertura-action against 5346e64

required={radioGroupProps.required}
>
{label}
{infoTooltip ? <InfoTooltip title={infoTooltip} /> : null}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

si tu veux éviter le ternaire tu peux faire comme ce que tu as fait à la ligne 41:

{Boolean(infoTooltip) && <InfoTooltip title={infoTooltip} />}

display: 'flex',
flexDirection: 'column',
gap: theme.spacing(1),
}))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

si possible mettre les styled components dans un fichier à part .styled.tsx (cf le composant CustomTable)
après on ne le fait peut-être pas systématiquement, je ne me souviens plus ce qu'on s'était dis

'metadata.entity': 'product',
}),
[]
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

si ça ne change jamais, tu peux déclarer ces variables à l'extérieur du composant (et du coup sans le useMemo)

@botisSmile botisSmile force-pushed the feat-1314737-BoostsAddProportionnalToAttributeComponent branch from 447e73e to 58c0771 Compare January 24, 2025 14:01
@matthias-goupil matthias-goupil force-pushed the feat-1314737-BoostsAddProportionnalToAttributeComponent branch from 0010a19 to 41a33d9 Compare January 27, 2025 13:40
@botisSmile botisSmile self-requested a review January 27, 2025 13:48
@matthias-goupil matthias-goupil force-pushed the feat-1314737-BoostsAddProportionnalToAttributeComponent branch 3 times, most recently from bf4bb99 to ca47726 Compare January 28, 2025 09:56
@matthias-goupil matthias-goupil force-pushed the feat-1314737-BoostsAddProportionnalToAttributeComponent branch from ca47726 to 5346e64 Compare January 28, 2025 10:17
@matthias-goupil matthias-goupil merged commit 6cfbfe1 into 2.0.x Jan 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants