Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Megamix #250

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update Megamix #250

wants to merge 3 commits into from

Conversation

RePod
Copy link
Contributor

@RePod RePod commented Feb 25, 2025

Unofficial 1.1.9 + diffed Cynichill/DivaAPworld#23 (mostly Client side) and Cynichill/DivaAPworld#28 (fuzz proofing)
This also includes the smaller JSON.

Pending ArchipelagoMW/Archipelago#4681 a lot will improve, but not soon.

@bananium-taskcluster
Copy link

Review changes

@RePod RePod marked this pull request as draft February 25, 2025 03:25
backported goal ID fix
@bananium-taskcluster
Copy link

Review changes

@RePod RePod marked this pull request as ready for review February 25, 2025 03:39
@Eijebong
Copy link
Owner

/taskcluster r+

@bananium-taskcluster
Copy link

@Eijebong
Copy link
Owner


[task 2025-02-25T17:57:42.982Z] ERROR:root:Could not load world WorldSource(/tmp/tmpp7seypx1/megamix.apworld, is_zip=True, relative=False):
[task 2025-02-25T17:57:42.982Z] Traceback (most recent call last):
[task 2025-02-25T17:57:42.982Z]   File "/ap/archipelago/worlds/__init__.py", line 88, in load
[task 2025-02-25T17:57:42.983Z]     importer.exec_module(mod)
[task 2025-02-25T17:57:42.983Z]   File "<frozen importlib._bootstrap_external>", line 940, in exec_module
[task 2025-02-25T17:57:42.983Z]   File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
[task 2025-02-25T17:57:42.983Z]   File "/tmp/tmpp7seypx1/megamix.apworld/megamix/__init__.py", line 46, in <module>
[task 2025-02-25T17:57:42.983Z]     class MegaMixWorld(World):
[task 2025-02-25T17:57:42.983Z]   File "/tmp/tmpp7seypx1/megamix.apworld/megamix/__init__.py", line 61, in MegaMixWorld
[task 2025-02-25T17:57:42.983Z]     mm_collection = MegaMixCollections()
[task 2025-02-25T17:57:42.983Z]                     ^^^^^^^^^^^^^^^^^^^^
[task 2025-02-25T17:57:42.984Z]   File "/tmp/tmpp7seypx1/megamix.apworld/megamix/MegaMixCollection.py", line 45, in __init__
[task 2025-02-25T17:57:42.984Z]     mod_data = extract_mod_data_to_json()
[task 2025-02-25T17:57:42.984Z]                ^^^^^^^^^^^^^^^^^^^^^^^^^^
[task 2025-02-25T17:57:42.984Z]   File "/tmp/tmpp7seypx1/megamix.apworld/megamix/DataHandler.py", line 196, in extract_mod_data_to_json
[task 2025-02-25T17:57:42.984Z]     for item in os.listdir(folder_path):
[task 2025-02-25T17:57:42.984Z]                 ^^^^^^^^^^^^^^^^^^^^^^^
[task 2025-02-25T17:57:42.985Z] FileNotFoundError: [Errno 2] No such file or directory: '/ap/archipelago/Players'

We're back at the apworld being mad for no reason

@bananium-taskcluster
Copy link

Review changes

@Eijebong
Copy link
Owner

/taskcluster r+

Thanks

@bananium-taskcluster
Copy link

@Eijebong
Copy link
Owner

Oh well, now it's proper angy

@RePod
Copy link
Contributor Author

RePod commented Feb 25, 2025

The isnumeric test is rough since 39 is the song name. It's just that until now difficulty information was in the item name such as 39 [EXTREME].

Fortunately create_item is isolated in usage but its signature was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants