Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add super mario sunshine #227

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add super mario sunshine #227

wants to merge 1 commit into from

Conversation

Eijebong
Copy link
Owner

No description provided.

@bananium-taskcluster
Copy link

Review changes

@Eijebong
Copy link
Owner Author

/taskcluster test

this makes use of the random module directly but the rest looks fine, not sure yet whether to reject it on that bases yet, let's see if tests convince me

@bananium-taskcluster
Copy link

Test failures for sms:0.4.1-alpha

@Eijebong
Copy link
Owner Author

No.

  • Direct use of the random module which should be avoided.
  • Tests failure for test_default_empty_state_can_reach_something is concerning
  • Two test failures because of FillError is concerning too

@Eijebong Eijebong added the blocked by apworld This is blocked by something in the apworld that needs to change label Feb 18, 2025
@Eijebong
Copy link
Owner Author

@Eijebong
Copy link
Owner Author

Worth noting that this failed 71/100 fuzz rounds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked by apworld This is blocked by something in the apworld that needs to change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant