remove redundant logic.

EdwinBetanc0urt · Jan 25, 2024 · 33e5fd9 · 33e5fd9
1 parent e764224
commit 33e5fd9
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 53 deletions.
diff --git a/src/components/ADempiere/Form/Issues/component/Comment.vue b/src/components/ADempiere/Form/Issues/component/Comment.vue
@@ -1246,33 +1246,13 @@
                       class="previwer-disable"
                       style="padding: 0px"
                     />
-                    <span v-else>
-                      <el-descriptions :column="1">
-                        <el-descriptions-item
-                          v-for="log in comment.change_logs"
-                          :key="log.id"
-                          label-style="{ color: #606266; font-weight: bold; }"
-                        >
-                          <template slot="label">
-                            <span style="color: #606266; font-weight: bold;padding-right: 5px;">
-                              {{ log.label }}
-                            </span>
-                            ({{ log.column_name }})
-                          </template>
-                          <span style="font-weight: bold;">
-                            <el-link
-                              :type="!isEmptyValue(log.displayed_value) ? 'success' : 'danger'"
-                              :style="isEmptyValue(log.displayed_value) ? 'text-decoration:line-through;' : ''"
-                            >
-                              <b>
-                                {{ isEmptyValue(log.displayed_value) ? 'NULL' : log.displayed_value }}
-                              </b>
-                            </el-link>
-                          </span>
-                        </el-descriptions-item>
-                      </el-descriptions>
-                    </span>
+                    <issue-log
+                      v-else-if="comment.issue_comment_type === 'LOG'"
+                      :comment="comment"
+                      class="list-comments"
+                    />
                   </span>
+
                   <span v-else>
                     <el-card v-if="commentUpdatePreview" shadow="never">
                       <el-scrollbar wrap-class="scroll-previwer-disable">

diff --git a/src/components/ADempiere/PanelInfo/Component/RecordIssues/component/Comment.vue b/src/components/ADempiere/PanelInfo/Component/RecordIssues/component/Comment.vue
@@ -1245,34 +1245,13 @@
                       class="previwer-disable"
                       style="padding: 0px"
                     />
-                    <span v-else>
-                      <el-descriptions :column="1">
-                        <el-descriptions-item
-                          v-for="log in comment.change_logs"
-                          :key="log.id"
-                          label-style="{ color: #606266; font-weight: bold; }"
-                        >
-                          <template slot="label">
-                            <span style="color: #606266; font-weight: bold;padding-right: 5px;">
-                              {{ log.label }}
-                            </span>
-                            ({{ log.column_name }})
-                          </template>
-                          <span style="font-weight: bold;">
-                            <el-link
-                              :type="!isEmptyValue(log.displayed_value) ? 'success' : 'danger'"
-                              :style="isEmptyValue(log.displayed_value) ? 'text-decoration:line-through;' : ''"
-                            >
-                              <b>
-                                {{ isEmptyValue(log.displayed_value) ? 'NULL' : log.displayed_value }}
-                              </b>
-                            </el-link>
-                          </span>
-                        </el-descriptions-item>
-                      </el-descriptions>
-                    </span>
+                    <issue-log
+                      v-else-if="comment.issue_comment_type === 'LOG'"
+                      :comment="comment"
+                      class="list-comments"
+                    />
                   </span>
-                  <v-md-preview v-if="!comment.isEdit" :text="comment.result" class="previwer-disable" style="padding: 0px" />
+
                   <span v-else>
                     <el-card v-if="commentUpdatePreview" shadow="never">
                       <el-scrollbar wrap-class="scroll-previwer-disable">