Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove duplicate update logic in gateway lwm2m #1092

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rhoninl
Copy link
Collaborator

@rhoninl rhoninl commented Dec 30, 2024

What this PR does / why we need it:
Auto update is same with InActvityMonitor in udpOptions, both of them will send update request with a interval. but the InactivityMonitor have reconnect logic in it, so remove duplicate action autoUpdate to avoid send too many update requrest.
Will this PR make the community happier?
yes
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

How is this PR tested

  • unit test
  • e2e test
  • other (please specify)

Special notes for your reviewer:
image

Release note:

Copy link

codecov bot commented Dec 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 33.06%. Comparing base (cfc8fd1) to head (79ba961).

Files with missing lines Patch % Lines
pkg/gateway/lwm2m/client/lwm2m.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1092      +/-   ##
==========================================
+ Coverage   32.96%   33.06%   +0.10%     
==========================================
  Files          55       55              
  Lines        4875     4860      -15     
==========================================
  Hits         1607     1607              
+ Misses       3128     3113      -15     
  Partials      140      140              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants