Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added fmt and clippy workflow from Reveaal #11

Merged
merged 46 commits into from
Dec 11, 2023
Merged

Added fmt and clippy workflow from Reveaal #11

merged 46 commits into from
Dec 11, 2023

Conversation

KamyaPA
Copy link
Contributor

@KamyaPA KamyaPA commented Dec 1, 2023

No description provided.

@KamyaPA KamyaPA self-assigned this Dec 1, 2023
@KamyaPA KamyaPA linked an issue Dec 1, 2023 that may be closed by this pull request
Add automatic linting (and testing?) of code #10
Closed
@KamyaPA KamyaPA marked this pull request as draft December 1, 2023 09:10
KamyaPA added 22 commits December 1, 2023 10:15
@KamyaPA
added glibc-sourve to workflow
206a815
@KamyaPA
added libgtk-3-dev to workflow
df10599
@KamyaPA
added libsoup-3.0-0 to workflow
4d1e4a8
@KamyaPA
changed libsoup in workflow
0db03f4
@KamyaPA
added webkit2gtk-driver to workflow
6849022
@KamyaPA
added javascriptcoregtk-4.0 to workflow
c9c8dc9
@KamyaPA
changed webkit2gtk in workflow
b42c49b
@KamyaPA
Added node dependencies
cfb9aba
@KamyaPA
added some cd to please yarn
64d2830
@KamyaPA
added submodules true to workflow
865a28a
@KamyaPA
added git submodules to workflow
b372d7a
@KamyaPA
fixed spellingmistake
2a17a3a
@KamyaPA
moved checkout in worspace
a419128
@KamyaPA
updated submodule url
bc5953a
@KamyaPA
added ls for testing in workflow
eb955ec
@KamyaPA
added node npm and yarn to workflow
a651045
@KamyaPA
fixed spelling mistake
3cecce3
@KamyaPA
added node go npm install
b2bc00f
@KamyaPA
force upgrade node
62d7b07
@KamyaPA
fixed unused package in submodule
231f1e4
@KamyaPA
Updated clippy workflow
2c3a8ee
@KamyaPA
removed --all-features
2873e2d
@KamyaPA KamyaPA marked this pull request as ready for review December 4, 2023 13:38
atjn
atjn approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@atjn atjn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I am no rust expert, please make sure the checks still work as they should after my changes. Thank you :)

DenFlyvendeGed
DenFlyvendeGed approved these changes Dec 11, 2023
View reviewed changes
Copy link

@DenFlyvendeGed DenFlyvendeGed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atjn atjn merged commit 5a26c1b into main Dec 11, 2023
2 checks passed
@atjn atjn deleted the 10-add-automatic-linting-and-testing-of-code branch December 11, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atjn atjn atjn approved these changes

@DenFlyvendeGed DenFlyvendeGed DenFlyvendeGed approved these changes

Assignees

@KamyaPA KamyaPA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add automatic linting (and testing?) of code
3 participants
@KamyaPA @atjn @DenFlyvendeGed