Fix memcached warning for php 5.6 #74
Conversation
|
|
||
| RUN mkdir -p /usr/src/php/ext; \ | ||
| cd /usr/src/php/ext/; \ | ||
| curl -sSL -o php7.zip https://github.com/websupport-sk/pecl-memcache/archive/NON_BLOCKING_IO_php7.zip; \ |
There was a problem hiding this comment.
Is this the correct version of memcache that we're using? The URL itself contains php7
There was a problem hiding this comment.
@mbtamuli URL contains php7 because of branch name. No official words in readme about php5.6 support but repo contains code for both PHP version 5 and 7 though need to test once.
There was a problem hiding this comment.
@sagarnasit Did you get a chance to test this?
There was a problem hiding this comment.
@sagarnasit Please add yourself also as maintainer.
php/5.6/Dockerfile
Outdated
| LABEL maintainer="Abhijit Rakas <[email protected]>" | ||
| LABEL org.label-schema.schema-version="1.0.0-rc1" | ||
| LABEL org.label-schema.vendor="EasyEngine" | ||
| LABEL org.label-schema.name="php" |
There was a problem hiding this comment.
We need another label to differentiate between the PHP7 and PHP5.6 containers. We can use org.label-schema.version as mentioned here - http://label-schema.org/rc1/
There was a problem hiding this comment.
@abhijitrakas Similarly for PHP7 image also, we need to add the label.
…jitrakas/dockerfiles into issue/install-memcached-ext
closes #EasyEngine/site-command#274