Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added/updated documentation and related files #10

Merged
merged 2 commits into from
Oct 27, 2023

Conversation

KrisThielemans
Copy link
Contributor

No description provided.

Before this, we crashed because of compilation warnings (converted to errors) in
system libraries such as chrono.
@KrisThielemans
Copy link
Contributor Author

This now fails with https://github.com/ETSInitiative/PRDdefinition/actions/runs/6665422649/job/18114961249?pr=10#step:7:60

/usr/share/miniconda/envs/yardl/x86_64-conda-linux-gnu/include/c++/12.3.0/bits/chrono.h:563:17: error: 'S' may be used uninitialized [-Werror=maybe-uninitialized]
  563 |           : __r(static_cast<rep>(__rep)) { }
      |                 ^~~~~~~~~~~~~~~~~~~~~~~
/usr/share/miniconda/envs/yardl/include/date/date.h: In static member function 'static void nlohmann::json_abi_v3_11_2::adl_serializer<std::chrono::time_point<std::chrono::_V2::system_clock, std::chrono::duration<long int, std::ratio<1, 1000000000> > > >::from_json(const nlohmann::json_abi_v3_11_2::ordered_json&, yardl::DateTime&)':
/usr/share/miniconda/envs/yardl/include/date/date.h:72[61](https://github.com/ETSInitiative/PRDdefinition/actions/runs/6665422649/job/18114961249?pr=10#step:7:62):37: note: 'S' declared here
 7261 |                         long double S;
      |                                     ^

@johnstairs @hansenms is there a way to keep Werror but ignore such problems? In the mean time, I'll disable this.

@KrisThielemans KrisThielemans merged commit bf50cac into ETSInitiative:main Oct 27, 2023
1 check passed
@KrisThielemans KrisThielemans deleted the extraDocs branch October 27, 2023 09:52
@johnstairs
Copy link
Contributor

It's strange that we haven't seen this before. It looks like the issue was fixed back in 2021 HowardHinnant/date#698 but there hasn't been a release since. We can put in an inline suppression in yardl :/

@KrisThielemans
Copy link
Contributor Author

I changed to depend on compilers, so it's using gcc 12.3.0, while previous runs where with 11.2.0. That's probably why.

I generally find -Werror very reliant on the compiler and external libraries doing the correct thing, but I don't know of a way to say "error on warnings on my code only"!

@johnstairs
Copy link
Contributor

I tried GCC 13.2.0 on the yardl and a bunch of warnings from dependencies (xtensor/xtl, date.h) pop up (not this one, interestingly). I'll investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants