Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for v2.9 in episode 9 #288

Merged
merged 4 commits into from
Aug 11, 2023
Merged

Updates for v2.9 in episode 9 #288

merged 4 commits into from
Aug 11, 2023

Conversation

LisaBock
Copy link
Contributor

@LisaBock LisaBock commented Jun 28, 2023

See also issue #278 and #282

Pull Request checklist

We appreciate your time and effort to improve the tutorial. Please keep in mind that lesson maintainers are volunteers and it may be some time before they can respond to your contribution.


Before you start

  • Read CONTRIBUTING.md.
  • Create an issue to discuss your idea. This allows your contributions to be incorporated into the tutorial.

Tasks

  • Give this pull request a descriptive title.
  • If you are contributing to existing lesson materials, please make sure the content conforms to the Lesson development section in CONTRIBUTING.md and does not contain any spelling or grammatical errors.
  • If you are making a new episode, please make sure the content conforms to the Lesson organization and Lesson formatting sections in CONTRIBUTING.md and does not contain any spelling or grammatical errors.
  • Preferably Codacy checks pass. Status can be seen below your pull request. If there is an error, click the link to find out why.
  • Preview changes on your machine before pushing them to GitHub by running make serve, alternatively make docker-serve. Please see the Previewing your changes locally section in CONTRIBUTING.md for installation instructions.
  • All code instructions have been tested.

If you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.


Closes {Link to the corresponding issue}

Copy link
Member

@SarahAlidoost SarahAlidoost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LisaBock changes look good, thanks 👍

@remi-kazeroni remi-kazeroni added the lesson Develop lessons material label Aug 11, 2023
@remi-kazeroni
Copy link
Contributor

Thanks @LisaBock and @SarahAlidoost!

@remi-kazeroni remi-kazeroni merged commit 588a761 into main Aug 11, 2023
@remi-kazeroni remi-kazeroni deleted the update_episode_9 branch August 11, 2023 14:08
ehogan pushed a commit to ehogan/ESMValTool_Tutorial that referenced this pull request Nov 21, 2024
* update diagnostic.py

* further updates

* update diagnostic.py

* update example regarding lazy data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lesson Develop lessons material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants