Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add preprocessor to extract surface values from 3D atmospheric variables #2641
base: main
Are you sure you want to change the base?
Add preprocessor to extract surface values from 3D atmospheric variables #2641
Changes from all commits
cc6944a
1e3d8bd
b20ecac
fb4e507
71ab37e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you looked into using the
esmvalcore.preprocessor.extract_levels
function?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to make it work but couldn't manage to. To replace the interpolation step I tried with
but I always get the following error
TypeError: extract_levels() missing 1 required positional argument: 'data'
which I don't really understand where it comes from. In case you have any insights on that.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be caused by the
preserve_float_dtype
decorator aroundextract_levels
. Usingavoids this problem. @schlunma Since you introduced the wrapper, would you have time to take a look at improving it to avoid this puzzling error?
Check notice on line 692 in esmvalcore/preprocessor/_volume.py
Codacy Production / Codacy Static Code Analysis
esmvalcore/preprocessor/_volume.py#L692