-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix undefined machine on cime6.0.217_httpsbranch branch #4598
Fix undefined machine on cime6.0.217_httpsbranch branch #4598
Conversation
This follows the logic in the _v2 version of this function. Resolves ESMCI#4588
If this could be merged and then tagged as cime6.0.217_httpsbranch03 that would be great. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for porting this over to this branch.
I ran the scripts regression testing script for an hour (until it ran out of wallclock). I could give it more time and restart. But, for this I think it's probably sufficient. Here's the output to show how far it got...
|
Initialize machine to None to prevent not initializing it to anything. This is cherry-picked
from #4596
Testing: Run CTSM python testing (which was failing before this change)
./scripts_regression_tests.py (currently running)
Test status: bit-for-bit
Fix for #4588 on the httpsbranch branch.
This fixes issues in CTSM discussed here:
ESCOMP/CTSM#2385 (comment)
User interface changes?: None
Update gh-pages html (Y/N)?: N