Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined machine on cime6.0.217_httpsbranch branch #4598

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

ekluzek
Copy link
Contributor

@ekluzek ekluzek commented Mar 12, 2024

Initialize machine to None to prevent not initializing it to anything. This is cherry-picked
from #4596

Testing: Run CTSM python testing (which was failing before this change)
./scripts_regression_tests.py (currently running)
Test status: bit-for-bit

Fix for #4588 on the httpsbranch branch.

This fixes issues in CTSM discussed here:

ESCOMP/CTSM#2385 (comment)

User interface changes?: None

Update gh-pages html (Y/N)?: N

This follows the logic in the _v2 version of this function.

Resolves ESMCI#4588
@ekluzek ekluzek added Responsibility: CESM Responsibility to manage and accomplish this issue is through CESM ty: Bug Fix Responsibility: CTSM Responsibility to manage and accomplish this issue is the CTSM Software group labels Mar 12, 2024
@ekluzek
Copy link
Contributor Author

ekluzek commented Mar 12, 2024

If this could be merged and then tagged as cime6.0.217_httpsbranch03 that would be great.

@jedwards4b @fischer-ncar

Copy link
Member

@billsacks billsacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for porting this over to this branch.

@ekluzek
Copy link
Contributor Author

ekluzek commented Mar 12, 2024

I ran the scripts regression testing script for an hour (until it ran out of wallclock). I could give it more time and restart. But, for this I think it's probably sufficient.

Here's the output to show how far it got...

Warning: no access to tty (Inappropriate ioctl for device).
Thus no job control in this shell.
Testing commit 3f6a58686ca3e98766ab1b858bf35fd2460e5f2e
Using cime_model = cesm
Testing machine = derecho
Test root: /glade/derecho/scratch/erik/scripts_regression_test.20240312_134924
Test driver: nuopc
Python version 3.7.9 | packaged by conda-forge | (default, Feb 13 2021, 20:03:11)
[GCC 9.3.0]

test_bless_test_results (test_sys_bless_tests_results.TestBlessTestResults) ... ok
test_rebless_namelist (test_sys_bless_tests_results.TestBlessTestResults) ... ok
test_clean_rebuild (test_sys_build_system.TestBuildSystem) ... ok
test_case_clean (test_sys_cime_case.TestCimeCase) ... ok
test_case_submit_interface (test_sys_cime_case.TestCimeCase) ... ok
test_cime_case (test_sys_cime_case.TestCimeCase) ... ok
test_cime_case_allow_failed_prereq (test_sys_cime_case.TestCimeCase) ... ok
test_cime_case_build_threaded_1 (test_sys_cime_case.TestCimeCase) ... ok
test_cime_case_build_threaded_2 (test_sys_cime_case.TestCimeCase) ... ok
test_cime_case_force_pecount (test_sys_cime_case.TestCimeCase) ... ok
test_cime_case_mpi_serial (test_sys_cime_case.TestCimeCase) ... ok
test_cime_case_prereq (test_sys_cime_case.TestCimeCase) ... ok
test_cime_case_resubmit_immediate (test_sys_cime_case.TestCimeCase) ... ok
test_cime_case_st_archive_resubmit (test_sys_cime_case.TestCimeCase) ... Successfully cleaned .case.run
Successfully cleaned .case.run
Successfully cleaned env_mach_specific.xml
Successfully cleaned env_mach_specific.xml
Successfully cleaned Macros.cmake
Successfully cleaned Macros.cmake
Successfully cleaned cmake_macros
Successfully cleaned cmake_macros
job is case.run USER_REQUESTED_WALLTIME 0:05:00 USER_REQUESTED_QUEUE None WALLTIME_FORMAT %H:%M:%S
job is case.run USER_REQUESTED_WALLTIME 0:05:00 USER_REQUESTED_QUEUE None WALLTIME_FORMAT %H:%M:%S
Creating batch scripts
Creating batch scripts
Writing case.run script from input template /glade/work/erik/ctsm_worktrees/b4b-dev/ccs_config/machines/template.case.run
Writing case.run script from input template /glade/work/erik/ctsm_worktrees/b4b-dev/ccs_config/machines/template.case.run
Creating file .case.run
Creating file .case.run
Writing case.st_archive script from input template /glade/work/erik/ctsm_worktrees/b4b-dev/ccs_config/machines/template.st_archive
Writing case.st_archive script from input template /glade/work/erik/ctsm_worktrees/b4b-dev/ccs_config/machines/template.st_archive
Creating file case.st_archive
Creating file case.st_archive
If an old case build already exists, might want to run 'case.build --clean' before building
If an old case build already exists, might want to run 'case.build --clean' before building
You can now run './preview_run' to get more info on how your case will be run
You can now run './preview_run' to get more info on how your case will be run
st_archive starting
st_archive starting
Cannot find a st_archive_resubmit_test.cpl*.r.*.nc file in directory /glade/derecho/scratch/erik/scripts_regression_test.20240312_134924/st_archive_resubmit_test/st_archive_resubmit_test/run
Cannot find a st_archive_resubmit_test.cpl*.r.*.nc file in directory /glade/derecho/scratch/erik/scripts_regression_test.20240312_134924/st_archive_resubmit_test/st_archive_resubmit_test/run
Archiving history files for drv (cpl)
Archiving history files for drv (cpl)
Archiving history files for dart (esp)
Archiving history files for dart (esp)
st_archive completed
st_archive completed
st_archive starting
st_archive starting
Cannot find a st_archive_resubmit_test.cpl*.r.*.nc file in directory /glade/derecho/scratch/erik/scripts_regression_test.20240312_134924/st_archive_resubmit_test/st_archive_resubmit_test/run
Cannot find a st_archive_resubmit_test.cpl*.r.*.nc file in directory /glade/derecho/scratch/erik/scripts_regression_test.20240312_134924/st_archive_resubmit_test/st_archive_resubmit_test/run
Archiving history files for drv (cpl)
Archiving history files for drv (cpl)
Archiving history files for dart (esp)
Archiving history files for dart (esp)
st_archive completed
st_archive completed
resubmitting from st_archive, resubmit=2
resubmitting from st_archive, resubmit=2

env_batch.xml appears to have changed, regenerating batch scripts
manual edits to these file will be lost!


env_batch.xml appears to have changed, regenerating batch scripts
manual edits to these file will be lost!

Creating batch scripts
Creating batch scripts
Writing case.run script from input template /glade/work/erik/ctsm_worktrees/b4b-dev/ccs_config/machines/template.case.run
Writing case.run script from input template /glade/work/erik/ctsm_worktrees/b4b-dev/ccs_config/machines/template.case.run
Creating file .case.run
Creating file .case.run
Writing case.st_archive script from input template /glade/work/erik/ctsm_worktrees/b4b-dev/ccs_config/machines/template.st_archive
Writing case.st_archive script from input template /glade/work/erik/ctsm_worktrees/b4b-dev/ccs_config/machines/template.st_archive
Creating file case.st_archive
Creating file case.st_archive
Submitting job 'case.run', resubmit=2
Submitting job 'case.run', resubmit=2
submit_jobs case.run
submit_jobs case.run
Submit job case.run
Submit job case.run
Submitting job script qsub -q main -l walltime=00:05:00 -A P93300041 -l job_priority=regular -v ARGS_FOR_SCRIPT='--resubmit' .case.run
Submitting job script qsub -q main -l walltime=00:05:00 -A P93300041 -l job_priority=regular -v ARGS_FOR_SCRIPT='--resubmit' .case.run
Submitted job id is 3789424.desched1
Submitted job id is 3789424.desched1
Submit job case.st_archive
Submit job case.st_archive
Submitting job script qsub -q main -l walltime=00:20:00 -A P93300041 -l job_priority=regular  -W depend=afterok:3789424.desched1 -v ARGS_FOR_SCRIPT='--resubmit' case.st_archive
Submitting job script qsub -q main -l walltime=00:20:00 -A P93300041 -l job_priority=regular  -W depend=afterok:3789424.desched1 -v ARGS_FOR_SCRIPT='--resubmit' case.st_archive
Submitted job id is 3789425.desched1
Submitted job id is 3789425.desched1
Submitted job case.run with id 3789424.desched1
Submitted job case.run with id 3789424.desched1
Submitted job case.st_archive with id 3789425.desched1
Submitted job case.st_archive with id 3789425.desched1
ok
test_cime_case_test_custom_project (test_sys_cime_case.TestCimeCase) ... ok
test_cime_case_test_walltime_mgmt_1 (test_sys_cime_case.TestCimeCase) ... skipped 'Skipping walltime test. Depends on E3SM batch settings'
test_cime_case_test_walltime_mgmt_2 (test_sys_cime_case.TestCimeCase) ... skipped 'Skipping walltime test. Depends on E3SM batch settings'
test_cime_case_test_walltime_mgmt_3 (test_sys_cime_case.TestCimeCase) ... skipped 'Skipping walltime test. Depends on E3SM batch settings'
test_cime_case_test_walltime_mgmt_4 (test_sys_cime_case.TestCimeCase) ... skipped 'Skipping walltime test. Depends on E3SM batch settings'
test_cime_case_test_walltime_mgmt_5 (test_sys_cime_case.TestCimeCase) ... skipped 'Skipping walltime test. Depends on E3SM batch settings'
test_cime_case_test_walltime_mgmt_6 (test_sys_cime_case.TestCimeCase) ... ok
test_cime_case_test_walltime_mgmt_7 (test_sys_cime_case.TestCimeCase) ... ok
test_cime_case_test_walltime_mgmt_8 (test_sys_cime_case.TestCimeCase) ... skipped 'Skipping walltime test. Depends on E3SM batch settings'
test_cime_case_xmlchange_append (test_sys_cime_case.TestCimeCase) ... ok
test_configure (test_sys_cime_case.TestCimeCase) ... ok
test_create_test_longname (test_sys_cime_case.TestCimeCase) ... ok
test_env_loading (test_sys_cime_case.TestCimeCase) ... skipped 'Skipping env load test - Only works on mappy'
test_self_build_cprnc (test_sys_cime_case.TestCimeCase) ... ok
test_xml_caching (test_sys_cime_case.TestCimeCase) ... ok
test_cime_case_ctrl_performance (test_sys_cime_performance.TestCimePerformance) ... ok
test_a_createnewcase (test_sys_create_newcase.TestCreateNewcase) ... =>> PBS: job killed: walltime 3638 exceeded limit 3600
Terminated

@billsacks billsacks merged commit cf099fb into ESMCI:cime6.0.217_httpsbranch Mar 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Responsibility: CESM Responsibility to manage and accomplish this issue is through CESM Responsibility: CTSM Responsibility to manage and accomplish this issue is the CTSM Software group ty: Bug Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants