-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove cprnc to new repo #4522
remove cprnc to new repo #4522
Conversation
@jedwards4b I'll need to push a few changes for E3SM to support this. |
@jasonb5 please do. I think you already have permissions but I'll confirm. |
Please also add an entry in .gitmodules for those of us using submodules. |
I see the problem - you are checking out cesm master which does not yet have the additional hook needed to checkout cprnc. I can't figure out where the external scripts used in testing.yml are located - (init_cime, init_e3sm, entrypoint.sh) |
@jedwards4b |
…o remove_cprnc
We're getting closer - thank you @jasonb5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your work on this, @jedwards4b!
@jedwards4b Looks like the cprnc repo is missing a Makefile required for one of the E3Sm tests. |
It shouldn't need a Makefile - it's a cmake build. |
Looks like there's a test script that was using the makefile file, I'll look into updating it to use cmake. |
@jasonb5 I think I have it fixed - should I push the change? |
@jedwards4b Go ahead and push it. |
@mnlevy1981 I'm trying to run the test_get_domain.sh script on derecho - it's looking for a file that doesn't exist: |
Here's the source for those files. Lines 26 to 28 in f5fd575
|
try to push since I don't have data for a local test |
That's fine, the changes look right, it's the same route I was on. |
Puts the cprnc program into it's own repo
Test suite: scripts_regression_tests on derecho
Test baseline:
Test namelist changes:
Test status: bit for bit
Fixes
User interface changes?: cprnc is now external and added with Externals_cime.cfg
This means that in your Externals.cfg you will need:
externals = Externals_cime.cfg
Update gh-pages html (Y/N)?: