Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove cprnc to new repo #4522

Merged
merged 23 commits into from
Dec 4, 2023
Merged

remove cprnc to new repo #4522

merged 23 commits into from
Dec 4, 2023

Conversation

jedwards4b
Copy link
Contributor

Puts the cprnc program into it's own repo
Test suite: scripts_regression_tests on derecho
Test baseline:
Test namelist changes:
Test status: bit for bit

Fixes

User interface changes?: cprnc is now external and added with Externals_cime.cfg
This means that in your Externals.cfg you will need:
externals = Externals_cime.cfg

Update gh-pages html (Y/N)?:

@jedwards4b jedwards4b requested a review from billsacks November 23, 2023 16:53
@jedwards4b jedwards4b self-assigned this Nov 23, 2023
@jasonb5
Copy link
Collaborator

jasonb5 commented Nov 29, 2023

@jedwards4b I'll need to push a few changes for E3SM to support this.

@jedwards4b
Copy link
Contributor Author

@jasonb5 please do. I think you already have permissions but I'll confirm.

@rljacob
Copy link
Member

rljacob commented Dec 1, 2023

Please also add an entry in .gitmodules for those of us using submodules.

@jedwards4b
Copy link
Contributor Author

I see the problem - you are checking out cesm master which does not yet have the additional hook needed to checkout cprnc. I can't figure out where the external scripts used in testing.yml are located - (init_cime, init_e3sm, entrypoint.sh)
@jasonb5 can you document these in testing.yml?

@jasonb5
Copy link
Collaborator

jasonb5 commented Dec 1, 2023

@jedwards4b checkout_externals is called in entrypoint.sh in the init_cesm function. I can add some documents to the testing workflow yaml.

@jedwards4b
Copy link
Contributor Author

We're getting closer - thank you @jasonb5

Copy link
Member

@billsacks billsacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your work on this, @jedwards4b!

@jasonb5
Copy link
Collaborator

jasonb5 commented Dec 4, 2023

@jedwards4b Looks like the cprnc repo is missing a Makefile required for one of the E3Sm tests.

@jedwards4b
Copy link
Contributor Author

It shouldn't need a Makefile - it's a cmake build.

@jasonb5
Copy link
Collaborator

jasonb5 commented Dec 4, 2023

Looks like there's a test script that was using the makefile file, I'll look into updating it to use cmake.

@jedwards4b
Copy link
Contributor Author

@jasonb5 I think I have it fixed - should I push the change?

@jasonb5
Copy link
Collaborator

jasonb5 commented Dec 4, 2023

@jedwards4b Go ahead and push it.

@jedwards4b
Copy link
Contributor Author

@mnlevy1981 I'm trying to run the test_get_domain.sh script on derecho - it's looking for a file that doesn't exist:
${inputdata_root}/cpl/gridmaps/oQU240/map_oQU240_to_ne4np4_aave.160614.nc

@jasonb5
Copy link
Collaborator

jasonb5 commented Dec 4, 2023

Here's the source for those files.

cime/docker/Dockerfile

Lines 26 to 28 in f5fd575

wget -O /cache/cpl/gridmaps/oQU240/map_oQU240_to_ne4np4_aave.160614.nc https://portal.nersc.gov/project/e3sm/inputdata/cpl/gridmaps/oQU240/map_oQU240_to_ne4np4_aave.160614.nc && \
wget -O /cache/share/domains/domain.ocn.ne4np4_oQU240.160614.nc https://portal.nersc.gov/project/e3sm/inputdata/share/domains/domain.ocn.ne4np4_oQU240.160614.nc && \
wget -O /cache/share/domains/domain.lnd.ne4np4_oQU240.160614.nc https://portal.nersc.gov/project/e3sm/inputdata/share/domains/domain.lnd.ne4np4_oQU240.160614.nc

@jedwards4b
Copy link
Contributor Author

try to push since I don't have data for a local test

@jasonb5
Copy link
Collaborator

jasonb5 commented Dec 4, 2023

That's fine, the changes look right, it's the same route I was on.

@jedwards4b jedwards4b merged commit 1c7eda6 into ESMCI:master Dec 4, 2023
7 checks passed
@jedwards4b jedwards4b deleted the remove_cprnc branch December 4, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants