Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add reset for individual filters #413

Merged
merged 13 commits into from
Nov 29, 2023

Conversation

A-Behairi
Copy link
Collaborator

this introduces a reset functionality for every filter type in eox-itemfilter. When a user chooses to assign values to the filter, a reset icon appears next to the filter title and allows to reset the properties of that specific filter.

Copy link
Collaborator

@silvester-pari silvester-pari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, works great! I chose a simpler icon (X) for now, I feel like this is easier on the eyes. I also tried to harmonize it with the "reset all" button.

image

I think we can merge this now, we can still keep looking for better icons in the future.

@silvester-pari silvester-pari changed the title feat: add reset filter functionality by type feat: add reset for individual filters Nov 29, 2023
@silvester-pari silvester-pari merged commit a415adc into main Nov 29, 2023
3 checks passed
@silvester-pari silvester-pari deleted the itemfilter/feat/reset-filter-by-type branch November 29, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants