Implement time-aware slider ticks as found in eodash
#186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spectrachrome
force-pushed
the
timecontrol/feature/sliderticks
branch
from
2cdfe75 to
318e99a
Compare
spectrachrome
changed the title
eodash slider tickseodash
spectrachrome
changed the title
eodasheodash
spectrachrome
requested review from
silvester-pari
and removed request for
silvester-pari
silvester-pari
approved these changes
Nov 15, 2023
This was referenced Dec 5, 2023
This was referenced Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request takes the slider ticks implementation from
eodashand translates it into a Lit component so that it can also easily be used by other applications.Screen.Recording.2023-11-15.at.11.06.21.mov
The logic generating the year marks has been fixed and is now working properly.