Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: align play button property with others (disablePlay-> play) #1450

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

silvester-pari
Copy link
Collaborator

@silvester-pari silvester-pari commented Dec 19, 2024

Implemented changes

This PR changes the disablePlay property into a play property to better align it with other properties such as slider and navigation. The default value is false.

This is a breaking change - make sure to also invert the logic (first disablePlay: true now becomes play: falseetc.)!

Checklist before requesting a review

Copy link

netlify bot commented Dec 19, 2024

Deploy Preview for eoxelements ready!

Name Link
🔨 Latest commit fc041a3
🔍 Latest deploy log https://app.netlify.com/sites/eoxelements/deploys/676406d98fdcd200080e4b72
😎 Deploy Preview https://deploy-preview-1450--eoxelements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@silvester-pari silvester-pari marked this pull request as ready for review December 19, 2024 11:46
@silvester-pari silvester-pari merged commit 73328a1 into main Dec 19, 2024
7 checks passed
@silvester-pari silvester-pari deleted the timecontrol/feat/play-rename branch December 19, 2024 11:46
@github-actions github-actions bot mentioned this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant