Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(style): adjust button styling, paddings, add css variable #1439

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

silvester-pari
Copy link
Collaborator

@silvester-pari silvester-pari commented Dec 16, 2024

Implemented changes

This PR introduces

  • fixes for button styling, alignment, padding
  • introduction of a css variable --navigation-button-display, if set to nonethe left/right buttons are hidden

Screenshots/Videos

Before

image

After

image

Checklist before requesting a review

@silvester-pari silvester-pari changed the title feat(style): adjust button styling, paddings, add css variable for hi… feat(style): adjust button styling, paddings, add css variable Dec 16, 2024
Copy link

netlify bot commented Dec 16, 2024

Deploy Preview for eoxelements ready!

Name Link
🔨 Latest commit 0f53be5
🔍 Latest deploy log https://app.netlify.com/sites/eoxelements/deploys/6760560fbd88ec0008d82724
😎 Deploy Preview https://deploy-preview-1439--eoxelements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@silvester-pari silvester-pari marked this pull request as ready for review December 16, 2024 16:34
Copy link
Member

@santilland santilland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would propose to have the play button not live on the same line as the label and previous / next buttons, and personally i liked the centered look.
You have in any case the larger picture of how this integrates with styles and other things, so if having them left aligned fits that better it is ok for me :)

@silvester-pari silvester-pari merged commit 1fe0bc7 into main Dec 17, 2024
7 checks passed
@silvester-pari silvester-pari deleted the timecontrol/feat/styling-improvements branch December 17, 2024 13:13
@github-actions github-actions bot mentioned this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants