Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cursor-change after layer-interaction update #1434

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

RobertOrthofer
Copy link
Collaborator

@RobertOrthofer RobertOrthofer commented Dec 16, 2024

Implemented changes

This PR fixes an issue described in #1404, where the cursor did not change correctly when the interaction was added by updating an existing layer.
The issue was that in #1348 the interactions were taken from the properties of the ol-layer directly instead of the _jsonDefinition or the interactions or the eoxMap.

A test was added to test both the cursor as well as the select-interaction itself if the interaction was added after a delay.

Screenshots/Videos

Checklist before requesting a review

Copy link

netlify bot commented Dec 16, 2024

Deploy Preview for eoxelements ready!

Name Link
🔨 Latest commit 19189e3
🔍 Latest deploy log https://app.netlify.com/sites/eoxelements/deploys/676047a8d7914a0008a6a524
😎 Deploy Preview https://deploy-preview-1434--eoxelements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@A-Behairi A-Behairi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@RobertOrthofer RobertOrthofer merged commit 3bc9d95 into main Dec 18, 2024
7 checks passed
@RobertOrthofer RobertOrthofer deleted the map/fix/update-interaction-pointer branch December 18, 2024 11:15
@github-actions github-actions bot mentioned this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants