Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(style): replace bg colors with css variables #1430

Merged
merged 8 commits into from
Dec 17, 2024

Conversation

radupasparuga
Copy link
Collaborator

Implemented changes

In this PR we remove some hard coded background colors and replace them with css variables so that elements are easier to customize

Screenshots/Videos

Checklist before requesting a review

Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for eoxelements ready!

Name Link
🔨 Latest commit b11d89e
🔍 Latest deploy log https://app.netlify.com/sites/eoxelements/deploys/67617c4b33008c00083eabc6
😎 Deploy Preview https://deploy-preview-1430--eoxelements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@silvester-pari silvester-pari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for looking into this! I had a quick look and found some small things:

  • good idea to use the var, but maybe we should set it to transparent as fallback: --background-color: var(--eox-background-color, transparent);. Currently the fallback is white, and then we'd need to manually set it to transparent. Affects: drawtools (see editor story), itemfilter, layercontrol
  • some elements are missing. Affects: itemfilter, jsonform (.CodeMirror)
    (see screenshots)

image
image
image
image
image

@silvester-pari silvester-pari changed the title chore: replace bg colors with css variables fix(style): replace bg colors with css variables Dec 12, 2024
Copy link
Collaborator

@silvester-pari silvester-pari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@silvester-pari silvester-pari merged commit 23c74dd into main Dec 17, 2024
7 checks passed
@silvester-pari silvester-pari deleted the elements/fix/remove-hard-coded-background branch December 17, 2024 15:09
@github-actions github-actions bot mentioned this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants