-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(style): replace bg colors with css variables #1430
fix(style): replace bg colors with css variables #1430
Conversation
✅ Deploy Preview for eoxelements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for looking into this! I had a quick look and found some small things:
- good idea to use the var, but maybe we should set it to transparent as fallback:
--background-color: var(--eox-background-color, transparent);
. Currently the fallback is white, and then we'd need to manually set it to transparent. Affects: drawtools (see editor story), itemfilter, layercontrol - some elements are missing. Affects: itemfilter, jsonform (
.CodeMirror
)
(see screenshots)
…move-hard-coded-background
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Implemented changes
In this PR we remove some hard coded background colors and replace them with css variables so that elements are easier to customize
Screenshots/Videos
Checklist before requesting a review