Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: chips for pre-set filters #1407

Merged
merged 5 commits into from
Dec 9, 2024
Merged

Conversation

srijitcoder
Copy link
Member

@srijitcoder srijitcoder commented Dec 3, 2024

Implemented changes

  • Added chips to the inline mode when state is declared at the init.
  • Added it to be part of all the types.

Screenshots/Videos

image

Checklist before requesting a review

Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for eoxelements ready!

Name Link
🔨 Latest commit 63088ac
🔍 Latest deploy log https://app.netlify.com/sites/eoxelements/deploys/67501efbc7535b00084259a0
😎 Deploy Preview https://deploy-preview-1407--eoxelements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@srijitcoder srijitcoder changed the title Fix: chipinline invisible issue Minor: chip inline invisible issue on init Dec 4, 2024
@srijitcoder srijitcoder added the bug Something isn't working label Dec 4, 2024
@srijitcoder srijitcoder linked an issue Dec 4, 2024 that may be closed by this pull request
@srijitcoder srijitcoder changed the title Minor: chip inline invisible issue on init Minor: chip inline invisible on pre-set filters Dec 4, 2024
@srijitcoder srijitcoder marked this pull request as ready for review December 4, 2024 09:24
Copy link
Collaborator

@silvester-pari silvester-pari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@silvester-pari silvester-pari changed the title Minor: chip inline invisible on pre-set filters fix: chip for pre-set filters Dec 9, 2024
@silvester-pari silvester-pari changed the title fix: chip for pre-set filters fix: chips for pre-set filters Dec 9, 2024
@silvester-pari silvester-pari merged commit 694b994 into main Dec 9, 2024
7 checks passed
@silvester-pari silvester-pari deleted the itemfilter/fix/chips-inline-mode branch December 9, 2024 10:04
@github-actions github-actions bot mentioned this pull request Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pre-set filters do not show up in chips in inline mode
2 participants