Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable configuring the projection of emitted features #1356

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

A-Behairi
Copy link
Collaborator

@A-Behairi A-Behairi commented Nov 6, 2024

This closes #1275 by introducing projection attribute to EOxDrawTools to set the projection of the emitted features. The emitted features are transformed clones of the features on the map, in case the projection is explicitly set to a falsy value for example undefined the original features will be emitted.

Screenshots/Videos

Checklist before requesting a review

@A-Behairi A-Behairi requested a review from santilland November 6, 2024 11:16
Copy link

netlify bot commented Nov 6, 2024

Deploy Preview for eoxelements ready!

Name Link
🔨 Latest commit 231a8b3
🔍 Latest deploy log https://app.netlify.com/sites/eoxelements/deploys/672b7e2a938d6c0008b9fb8f
😎 Deploy Preview https://deploy-preview-1356--eoxelements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@silvester-pari
Copy link
Collaborator

Thank you @A-Behairi. What happens if it's a projection other than the two included ones? Will the transform still work?
The map has probably registered a new projection at that point (using e.g.

registerProjectionFromCode = registerProjectionFromCode;
), but I'm unsure if that also works for the feature transform automatically.

Also, please provide some story and a test for this new feature 😊

@A-Behairi
Copy link
Collaborator Author

Thanks for the feedback. I created a story showcasing the possibility of adding another projection, so it would work normally if the projection is registered on the map, but it will throw an error if it's not.

Copy link
Member

@santilland santilland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to go, any other thoughts @silvester-pari ?
Thank you @A-Behairi i think this is a very practical feature we for sure need

@silvester-pari silvester-pari merged commit 414e908 into main Nov 7, 2024
7 checks passed
@silvester-pari silvester-pari deleted the drawtools/feat/emitted-projection branch November 7, 2024 12:32
@github-actions github-actions bot mentioned this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow configuring expected coordinates projection for exported features
3 participants