-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable configuring the projection of emitted features #1356
Conversation
✅ Deploy Preview for eoxelements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thank you @A-Behairi. What happens if it's a projection other than the two included ones? Will the transform still work? EOxElements/elements/map/src/main.js Line 479 in 71bc295
Also, please provide some story and a test for this new feature 😊 |
Thanks for the feedback. I created a story showcasing the possibility of adding another projection, so it would work normally if the projection is registered on the map, but it will throw an error if it's not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good to go, any other thoughts @silvester-pari ?
Thank you @A-Behairi i think this is a very practical feature we for sure need
This closes #1275 by introducing
projection
attribute toEOxDrawTools
to set the projection of the emitted features. The emitted features are transformed clones of the features on the map, in case the projection is explicitly set to a falsy value for exampleundefined
the original features will be emitted.Screenshots/Videos
Checklist before requesting a review