Support for v2.23 emod release #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eter to "Released_Ratio" parameter. The tests will not pass until emod-malaria is updated
…e type of migration). The new vector_migration_example and reporter tests will throw errors until emod-malaria is updated the the latest EMOD code.
…o figure it out from words.
This was referenced Oct 30, 2024
- "For drug Vehicle, could not convert string to float: ''"
…ault_from_schema. Adjusted.
stitova-idm
commented
Oct 31, 2024
… linux-friendly; .uid cannot be written to a file directly as it is a UUID and not a string, so changing uid.hex and .uid to .id which is str(uid).
Bridenbecker
requested changes
Oct 31, 2024
| """ | ||
| In this example, we add vector genetics to the vector population and insecticide resistance, | ||
| adds a VectorGeneticsReporter. | ||
| The important bits are in set_param_fn, build_campaign. |
There was a problem hiding this comment.
This description needs to be updated. Definitely need to include that this demonstrates the vector surveillance.
I'm just noticing that there is a vector surveillance example. If this is just a copy and paste plus adding migration, then I'm not sure this is what we need. I can handle leaving it for now, but would appreciate a big comment saying that we need to simplify the example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support for EMOD v2.23 release (packaged into emod-malaria 0.0.72).