-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release CI #44
Add release CI #44
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets discuss my comments or edit please
- os: windows-latest | ||
build_name: serial.exe | ||
- os: macos-latest | ||
build_name: serial |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have we tested and confirmed that this will run correctly on windows and mac targets, if not we should or we should leave these targets out until we do.
## Setup | ||
### If your are on x86 linux |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should actually leave these instructions in but under a development header instead of a setup header. BUt they are useful for people who want to contribute to the project.
## Development | ||
Write your code and write tests | ||
1. Install the Android Debug Bridge (ADB) on your computer (don't worry about instructions for installing it on a phone/device yet). You can find instructions for doing so on your platform [here](https://www.xda-developers.com/install-adb-windows-macos-linux/#how-to-set-up-adb-on-your-computer). | ||
2. Download the latest rayhunter release bundle and unzip it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
link to this
The goal here is to get rid of any steps users would have to take to build rayhunter or the related install toolchain. Instead, a single release.zip file is produced on changes to
main
that contains precompiled arm32 binaries for rayhunter-daemon and the rootshell, along with built copies of theserial
binary for linux/mac/windows.Now a user only has to install adb, download the zip, and run a script to install rayhunter