Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for setting the exact required memory #214

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

smoors
Copy link
Collaborator

@smoors smoors commented Dec 1, 2024

this is useful in 2 use cases:

  • when testing a PR, to make sure the memory requirements are ok
  • when comparing performance between partitions with different amounts of memory available

@casparvl casparvl added this to the v0.4.1 milestone Dec 11, 2024
Copy link
Collaborator

@casparvl casparvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works like a charm.

Again, just want to make sure that your changes to the logging in hooks.py were intentional. If so, this is good to go.

@casparvl
Copy link
Collaborator

casparvl commented Dec 11, 2024

Oh, fun fact: I tried with the LAMMPS test. That now got killed by the OOM killer xD So I guess your feature is a useful one, and I guess that memory requirement needs to be increased... #217

@smoors
Copy link
Collaborator Author

smoors commented Dec 12, 2024

Again, just want to make sure that your changes to the logging in hooks.py were intentional. If so, this is good to go.

yes, intentional :)
just making sure we're always using reframe warnings + some simplifications

@casparvl
Copy link
Collaborator

casparvl commented Jan 9, 2025

@smoors if you can resolve the conflict, this is ready to be merged imho

@casparvl casparvl merged commit 695b7b2 into EESSI:main Jan 9, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants