use mixin class for pytorch #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casparvl
reviewed
Dec 11, 2024
casparvl
reviewed
Dec 11, 2024
There was a problem hiding this comment.
I think this is ok. The only thing we could potentially still remove is the device_type = variable(str) in the base class. Setting that device type is enforced by the eessi_mixin class anyway, as it will complain if you don't. But, up to you. If you have strong feelings about keeping it, I'm ok as well.
Also: tested on GPU and CPU, both work fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
still needs testing the required memory per node
EDIT: 1GB per core seems to be enough, ready for review