Skip to content

Commit

Permalink
Merge pull request #237 from casparvl/use_latest_release_ci
Browse files Browse the repository at this point in the history
Use latest release ci
  • Loading branch information
smoors authored Feb 2, 2025
2 parents 7d00c05 + 910ea52 commit 1949e5e
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 13 deletions.
11 changes: 0 additions & 11 deletions .github/workflows/check_versions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,21 +22,10 @@ jobs:
# Prepend fallback version with 'v', as that is also the case for the other two version strings
fallback_version="v$fallback_version"
# Get version from run_reframe.sh
run_reframe_testsuite_version=$(grep -oP 'EESSI_TESTSUITE_BRANCH\s*=\s*[^v]*\K[^"\x27]*' "CI/run_reframe.sh")
# Grab the tag for the highest version, by sorting by (semantic) version, and then filtering on patterns
# that match a pattern like v0.1.2. Finally, we grab the last to get the highest version
most_recent_version=$(git tag --sort=version:refname | grep -P "v[0-9]+\.[0-9]+\.[0-9]+" | tail -n 1)
echo "Testing if fallback version and EESSI_TESTSUITE_BRANCH version in CI/run_reframe.sh are the same"
if [[ "$fallback_version" != "$run_reframe_testsuite_version" ]]; then
echo "Version $fallback_version not equal to $run_reframe_testsuite_version"
exit 1
else
echo "... yes!"
fi
echo "Testing if fallback version and most recent version tag are the same"
if [[ "$fallback_version" != "$most_recent_version" ]]; then
echo "Version $fallback_version not equal to $most_recent_version"
Expand Down
9 changes: 8 additions & 1 deletion CI/run_reframe.sh
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,14 @@ if [ -z "${EESSI_TESTSUITE_URL}" ]; then
EESSI_TESTSUITE_URL='https://github.com/EESSI/test-suite.git'
fi
if [ -z "${EESSI_TESTSUITE_BRANCH}" ]; then
EESSI_TESTSUITE_BRANCH='v0.5.0'
git clone -n --depth=1 --filter=tree:0 ${EESSI_TESTSUITE_URL} "${TEMPDIR}/test-suite-version-checkout"
cd "${TEMPDIR}/test-suite-version-checkout"
git fetch --tags
# This assumes we stick to a version-tagging scheme vX.Y.Z
LATEST_VERSION=$(git tag | grep '^v[0-9]\+\.[0-9]\+\.[0-9]\+$' | sort -t. -k 1,1n -k 2,2n -k 3,3n | tail -1)
# Use the latest release by default
EESSI_TESTSUITE_BRANCH="${LATEST_VERSION}"
cd ${TEMPDIR}
fi
if [ -z "${EESSI_CONFIGS_TESTSUITE_URL}" ]; then
EESSI_CONFIGS_TESTSUITE_URL="${EESSI_TESTSUITE_URL}"
Expand Down
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,6 @@ are ok with that_ before doing so!
When a release of the EESSI test suite is made, the following things must be taken care of:

- Version bump the `fallback_version` in `pyproject.toml`;
- Version bump the default `EESSI_TESTSUITE_BRANCH` in `CI/run_reframe.sh`;
- Create release notes PR: an easy way to get an overview of PRs since the latest release is using figuring out the date of the latest tag, and check all merged PRs since then (e.g. `is:pr is:closed merged:2024-09-25..2025-01-23`) (cfr. https://github.com/EESSI/test-suite/pull/231)
- Merge release notes PR (N.B. the CI test checking the fallback_version against the latest tagged version will fail, this is a chicken-and-egg problem, so we just have to merge anyway)
- Click 'Draft a new release' on https://github.com/EESSI/test-suite/releases . In the process, create a new tag, and copy the release nodes into the text box. Save as draft, check it, then publish the release.
Expand Down

0 comments on commit 1949e5e

Please sign in to comment.