Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar #47

Closed
wants to merge 7 commits into from
Closed

Sidebar #47

wants to merge 7 commits into from

Conversation

rajesh6161
Copy link
Member

Fixes #18

Description

Include a summary of the change and relevant motivation/context. List any dependencies that are required for this change.

Type of change

  • New feature (non-breaking change which adds functionality pre-approved by mentors)
  • Bug fix (non-breaking change which fixes an issue)
  • Refactor
  • Addition of testcases
  • This change requires a documentation update (software upgrade on readme file)

Screenshots of change:

Describe the tests you ran to verify your changes. Provide instructions or GIFs so we can reproduce. List any relevant details for your test.

Checklist:

  • My PR follows the style guidelines of this project
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • I have updated storybook
  • I have updated README.md
  • Added new npm packages

Code/Quality Assurance

  • My changes generate no new warnings
  • My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
  • New and existing tests pass locally with my changes

@kaushik27mishra
Copy link

kaushik27mishra commented Feb 22, 2021

The basic setup of the drawer looks good! Just make it more like what's there in the design!

@kaushik27mishra
Copy link

We have to make it role-based and once it's wired up with the API we will go ahead and merge it!

@kaushik27mishra
Copy link

On the 13.3 inch screen, it looks a little weird can you go ahead and fix that!
Screenshot from 2021-02-22 15-49-07

@rajesh6161 rajesh6161 closed this Feb 27, 2021
@rajesh6161 rajesh6161 mentioned this pull request Feb 27, 2021
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Side Drawer to handle Org and group navigations
2 participants