i#5888: Avoid fatal error on lib copy collision #7264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switches from "cmake -E copy" to "cmake -E copy_if_different" for the Windows library cop[ies used for API standalone tests. We have seem sporadic fatal errors from drconfiglib.dll failing to copy, presumably because another rule already copied it. It has proven difficult to figure out which rules are colliding, so we solve this by making it a non-fatal error. Fixes #5888
edeiana
approved these changes
Feb 9, 2025
Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches from "cmake -E copy" to "cmake -E copy_if_different" for the Windows library copies used for API standalone tests. We have seen sporadic fatal errors from drconfiglib.dll failing to copy, presumably because another rule already copied it. It has proven difficult to figure out which rules are colliding, so we solve this by making it a non-fatal error.
Fixes #5888