i#7260: tool.drcacheoff.purestatic bug fix #7261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`tool.drcacheoff.purestatic` fails to build due to `libxxhash` missing. This library is used by `liblz4` in some cases, and must be statically linked when building the `tool.drcacheoff.purestatic` app, which we use in some tests. We update the doc adding `libxxhash-dev` to the list of packages that need to be installed to build DynamoRIO on Linux. Note: `tool.drcacheoff.purestatic` is currently only built in x64 Linux hosts. Fixes #7260
edeiana
commented
Feb 8, 2025
derekbruening
approved these changes
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tool.drcacheoff.purestaticfails to build due tolibxxhashmissing.This library is used by
liblz4in some cases, and must be staticallylinked when building the
tool.drcacheoff.purestaticapp, which weuse in some tests.
We update the doc adding
libxxhash-devto the list of packagesthat need to be installed to build DynamoRIO on Linux.
Note:
tool.drcacheoff.purestaticis currently only built in x64 Linux hosts.Fixes #7260