Skip to content

Commit

Permalink
i#5873: Explicitly request action for failing master merge tests
Browse files Browse the repository at this point in the history
As we've now removed the requirement for a branch to be up to date before merging to master,
there is a possibility of unintended regressions due to interactions between commits. Such
regressions can be detected by the post-merge test suite which serializes the commits.

Adds an explicit request to triage and fix the possible regression on master merge test
workflow failures.

Issue: #5873
  • Loading branch information
abhinav92003 committed Feb 14, 2025
1 parent d11ec3f commit 0685ff9
Show file tree
Hide file tree
Showing 9 changed files with 120 additions and 24 deletions.
30 changes: 25 additions & 5 deletions .github/workflows/ci-aarchxx-cross.yml
Original file line number Diff line number Diff line change
Expand Up @@ -107,10 +107,14 @@ jobs:
username: ${{secrets.DYNAMORIO_NOTIFICATION_EMAIL_USERNAME}}
password: ${{secrets.DYNAMORIO_NOTIFICATION_EMAIL_PASSWORD}}
subject: |
[${{github.repository}}] ${{github.workflow}} FAILED
[Author Action Required] [${{github.repository}}] ${{github.workflow}} FAILED
on ${{github.event_name}} at ${{github.ref}}
body: |
Github Actions CI workflow run FAILED!
Commit author must triage and fix the possible regression.
Ensure the failure is not due to commits merged from out-of-date branches (i#5873).
For flaky tests, file new issue or update existing one with details.
Please note the action taken in a response on this dynamorio-devs email thread.
Workflow: ${{github.workflow}}/aarchxx-cross-compile
Repository: ${{github.repository}}
Branch ref: ${{github.ref}}
Expand Down Expand Up @@ -180,10 +184,14 @@ jobs:
username: ${{secrets.DYNAMORIO_NOTIFICATION_EMAIL_USERNAME}}
password: ${{secrets.DYNAMORIO_NOTIFICATION_EMAIL_PASSWORD}}
subject: |
[${{github.repository}}] ${{github.workflow}} FAILED
[Author Action Required] [${{github.repository}}] ${{github.workflow}} FAILED
on ${{github.event_name}} at ${{github.ref}}
body: |
Github Actions CI workflow run FAILED!
Commit author must triage and fix the possible regression.
Ensure the failure is not due to commits merged from out-of-date branches (i#5873).
For flaky tests, file new issue or update existing one with details.
Please note the action taken in a response on this dynamorio-devs email thread.
Workflow: ${{github.workflow}}/aarchxx-cross-compile
Repository: ${{github.repository}}
Branch ref: ${{github.ref}}
Expand Down Expand Up @@ -252,10 +260,14 @@ jobs:
username: ${{secrets.DYNAMORIO_NOTIFICATION_EMAIL_USERNAME}}
password: ${{secrets.DYNAMORIO_NOTIFICATION_EMAIL_PASSWORD}}
subject: |
[${{github.repository}}] ${{github.workflow}} FAILED
[Author Action Required] [${{github.repository}}] ${{github.workflow}} FAILED
on ${{github.event_name}} at ${{github.ref}}
body: |
Github Actions CI workflow run FAILED!
Commit author must triage and fix the possible regression.
Ensure the failure is not due to commits merged from out-of-date branches (i#5873).
For flaky tests, file new issue or update existing one with details.
Please note the action taken in a response on this dynamorio-devs email thread.
Workflow: ${{github.workflow}}/android-arm-cross-compile
Repository: ${{github.repository}}
Branch ref: ${{github.ref}}
Expand Down Expand Up @@ -318,10 +330,14 @@ jobs:
username: ${{secrets.DYNAMORIO_NOTIFICATION_EMAIL_USERNAME}}
password: ${{secrets.DYNAMORIO_NOTIFICATION_EMAIL_PASSWORD}}
subject: |
[${{github.repository}}] ${{github.workflow}} FAILED
[Author Action Required] [${{github.repository}}] ${{github.workflow}} FAILED
on ${{github.event_name}} at ${{github.ref}}
body: |
Github Actions CI workflow run FAILED!
Commit author must triage and fix the possible regression.
Ensure the failure is not due to commits merged from out-of-date branches (i#5873).
For flaky tests, file new issue or update existing one with details.
Please note the action taken in a response on this dynamorio-devs email thread.
Workflow: ${{github.workflow}}/android-aarch64-cross-compile
Repository: ${{github.repository}}
Branch ref: ${{github.ref}}
Expand Down Expand Up @@ -378,10 +394,14 @@ jobs:
username: ${{secrets.DYNAMORIO_NOTIFICATION_EMAIL_USERNAME}}
password: ${{secrets.DYNAMORIO_NOTIFICATION_EMAIL_PASSWORD}}
subject: |
[${{github.repository}}] ${{github.workflow}} FAILED
[Author Action Required] [${{github.repository}}] ${{github.workflow}} FAILED
on ${{github.event_name}} at ${{github.ref}}
body: |
Github Actions CI workflow run FAILED!
Commit author must triage and fix the possible regression.
Ensure the failure is not due to commits merged from out-of-date branches (i#5873).
For flaky tests, file new issue or update existing one with details.
Please note the action taken in a response on this dynamorio-devs email thread.
Workflow: ${{github.workflow}}/a64-on-x86
Repository: ${{github.repository}}
Branch ref: ${{github.ref}}
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/ci-aarchxx.yml
Original file line number Diff line number Diff line change
Expand Up @@ -137,10 +137,14 @@ jobs:
username: ${{secrets.DYNAMORIO_NOTIFICATION_EMAIL_USERNAME}}
password: ${{secrets.DYNAMORIO_NOTIFICATION_EMAIL_PASSWORD}}
subject: |
[${{github.repository}}] ${{github.workflow}} FAILED
[Author Action Required] [${{github.repository}}] ${{github.workflow}} FAILED
on ${{github.event_name}} at ${{github.ref}}
body: |
Github Actions CI workflow run FAILED!
Commit author must triage and fix the possible regression.
Ensure the failure is not due to commits merged from out-of-date branches (i#5873).
For flaky tests, file new issue or update existing one with details.
Please note the action taken in a response on this dynamorio-devs email thread.
Workflow: ${{github.workflow}}/x86-32
Repository: ${{github.repository}}
Branch ref: ${{github.ref}}
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/ci-clang-format.yml
Original file line number Diff line number Diff line change
Expand Up @@ -96,10 +96,14 @@ jobs:
username: ${{secrets.DYNAMORIO_NOTIFICATION_EMAIL_USERNAME}}
password: ${{secrets.DYNAMORIO_NOTIFICATION_EMAIL_PASSWORD}}
subject: |
[${{github.repository}}] ${{github.workflow}} FAILED
[Author Action Required] [${{github.repository}}] ${{github.workflow}} FAILED
on ${{github.event_name}} at ${{github.ref}}
body: |
Github Actions CI workflow run FAILED!
Commit author must triage and fix the possible regression.
Ensure the failure is not due to commits merged from out-of-date branches (i#5873).
For flaky tests, file new issue or update existing one with details.
Please note the action taken in a response on this dynamorio-devs email thread.
Workflow: ${{github.workflow}}/clang-format
Repository: ${{github.repository}}
Branch ref: ${{github.ref}}
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/ci-docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -139,10 +139,14 @@ jobs:
username: ${{secrets.DYNAMORIO_NOTIFICATION_EMAIL_USERNAME}}
password: ${{secrets.DYNAMORIO_NOTIFICATION_EMAIL_PASSWORD}}
subject: |
[${{github.repository}}] ${{github.workflow}} FAILED
[Author Action Required] [${{github.repository}}] ${{github.workflow}} FAILED
on ${{github.event_name}} at ${{github.ref}}
body: |
Github Actions CI workflow run FAILED!
Commit author must triage and fix the possible regression.
Ensure the failure is not due to commits merged from out-of-date branches (i#5873).
For flaky tests, file new issue or update existing one with details.
Please note the action taken in a response on this dynamorio-devs email thread.
Workflow: ${{github.workflow}}/docs
Repository: ${{github.repository}}
Branch ref: ${{github.ref}}
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/ci-osx.yml
Original file line number Diff line number Diff line change
Expand Up @@ -95,10 +95,14 @@ jobs:
username: ${{secrets.DYNAMORIO_NOTIFICATION_EMAIL_USERNAME}}
password: ${{secrets.DYNAMORIO_NOTIFICATION_EMAIL_PASSWORD}}
subject: |
[${{github.repository}}] ${{github.workflow}} FAILED
[Author Action Required] [${{github.repository}}] ${{github.workflow}} FAILED
on ${{github.event_name}} at ${{github.ref}}
body: |
Github Actions CI workflow run FAILED!
Commit author must triage and fix the possible regression.
Ensure the failure is not due to commits merged from out-of-date branches (i#5873).
For flaky tests, file new issue or update existing one with details.
Please note the action taken in a response on this dynamorio-devs email thread.
Workflow: ${{github.workflow}}/osx-x86-64
Repository: ${{github.repository}}
Branch ref: ${{github.ref}}
Expand Down
36 changes: 30 additions & 6 deletions .github/workflows/ci-package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -142,10 +142,14 @@ jobs:
username: ${{secrets.DYNAMORIO_NOTIFICATION_EMAIL_USERNAME}}
password: ${{secrets.DYNAMORIO_NOTIFICATION_EMAIL_PASSWORD}}
subject: |
[${{github.repository}}] ${{github.workflow}} FAILED
[Author Action Required] [${{github.repository}}] ${{github.workflow}} FAILED
on ${{github.event_name}} at ${{github.ref}}
body: |
Github Actions CI workflow run FAILED!
Commit author must triage and fix the possible regression.
Ensure the failure is not due to commits merged from out-of-date branches (i#5873).
For flaky tests, file new issue or update existing one with details.
Please note the action taken in a response on this dynamorio-devs email thread.
Workflow: ${{github.workflow}}/linux-x86
Repository: ${{github.repository}}
Branch ref: ${{github.ref}}
Expand Down Expand Up @@ -231,10 +235,14 @@ jobs:
username: ${{secrets.DYNAMORIO_NOTIFICATION_EMAIL_USERNAME}}
password: ${{secrets.DYNAMORIO_NOTIFICATION_EMAIL_PASSWORD}}
subject: |
[${{github.repository}}] ${{github.workflow}} FAILED
[Author Action Required] [${{github.repository}}] ${{github.workflow}} FAILED
on ${{github.event_name}} at ${{github.ref}}
body: |
Github Actions CI workflow run FAILED!
Commit author must triage and fix the possible regression.
Ensure the failure is not due to commits merged from out-of-date branches (i#5873).
For flaky tests, file new issue or update existing one with details.
Please note the action taken in a response on this dynamorio-devs email thread.
Workflow: ${{github.workflow}}/linux-aarch64
Repository: ${{github.repository}}
Branch ref: ${{github.ref}}
Expand Down Expand Up @@ -320,10 +328,14 @@ jobs:
username: ${{secrets.DYNAMORIO_NOTIFICATION_EMAIL_USERNAME}}
password: ${{secrets.DYNAMORIO_NOTIFICATION_EMAIL_PASSWORD}}
subject: |
[${{github.repository}}] ${{github.workflow}} FAILED
[Author Action Required] [${{github.repository}}] ${{github.workflow}} FAILED
on ${{github.event_name}} at ${{github.ref}}
body: |
Github Actions CI workflow run FAILED!
Commit author must triage and fix the possible regression.
Ensure the failure is not due to commits merged from out-of-date branches (i#5873).
For flaky tests, file new issue or update existing one with details.
Please note the action taken in a response on this dynamorio-devs email thread.
Workflow: ${{github.workflow}}/linux-arm
Repository: ${{github.repository}}
Branch ref: ${{github.ref}}
Expand Down Expand Up @@ -411,10 +423,14 @@ jobs:
username: ${{secrets.DYNAMORIO_NOTIFICATION_EMAIL_USERNAME}}
password: ${{secrets.DYNAMORIO_NOTIFICATION_EMAIL_PASSWORD}}
subject: |
[${{github.repository}}] ${{github.workflow}} FAILED
[Author Action Required] [${{github.repository}}] ${{github.workflow}} FAILED
on ${{github.event_name}} at ${{github.ref}}
body: |
Github Actions CI workflow run FAILED!
Commit author must triage and fix the possible regression.
Ensure the failure is not due to commits merged from out-of-date branches (i#5873).
For flaky tests, file new issue or update existing one with details.
Please note the action taken in a response on this dynamorio-devs email thread.
Workflow: ${{github.workflow}}/android-arm
Repository: ${{github.repository}}
Branch ref: ${{github.ref}}
Expand Down Expand Up @@ -503,10 +519,14 @@ jobs:
username: ${{secrets.DYNAMORIO_NOTIFICATION_EMAIL_USERNAME}}
password: ${{secrets.DYNAMORIO_NOTIFICATION_EMAIL_PASSWORD}}
subject: |
[${{github.repository}}] ${{github.workflow}} FAILED
[Author Action Required] [${{github.repository}}] ${{github.workflow}} FAILED
on ${{github.event_name}} at ${{github.ref}}
body: |
Github Actions CI workflow run FAILED!
Commit author must triage and fix the possible regression.
Ensure the failure is not due to commits merged from out-of-date branches (i#5873).
For flaky tests, file new issue or update existing one with details.
Please note the action taken in a response on this dynamorio-devs email thread.
Workflow: ${{github.workflow}}/windows
Repository: ${{github.repository}}
Branch ref: ${{github.ref}}
Expand Down Expand Up @@ -655,10 +675,14 @@ jobs:
username: ${{secrets.DYNAMORIO_NOTIFICATION_EMAIL_USERNAME}}
password: ${{secrets.DYNAMORIO_NOTIFICATION_EMAIL_PASSWORD}}
subject: |
[${{github.repository}}] ${{github.workflow}} FAILED
[Author Action Required] [${{github.repository}}] ${{github.workflow}} FAILED
on ${{github.event_name}} at ${{github.ref}}
body: |
Github Actions CI workflow run FAILED!
Commit author must triage and fix the possible regression.
Ensure the failure is not due to commits merged from out-of-date branches (i#5873).
For flaky tests, file new issue or update existing one with details.
Please note the action taken in a response on this dynamorio-devs email thread.
Workflow: ${{github.workflow}}/create_release
Repository: ${{github.repository}}
Branch ref: ${{github.ref}}
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/ci-riscv64.yml
Original file line number Diff line number Diff line change
Expand Up @@ -110,10 +110,14 @@ jobs:
username: ${{secrets.DYNAMORIO_NOTIFICATION_EMAIL_USERNAME}}
password: ${{secrets.DYNAMORIO_NOTIFICATION_EMAIL_PASSWORD}}
subject: |
[${{github.repository}}] ${{github.workflow}} FAILED
[Author Action Required] [${{github.repository}}] ${{github.workflow}} FAILED
on ${{github.event_name}} at ${{github.ref}}
body: |
Github Actions CI workflow run FAILED!
Commit author must triage and fix the possible regression.
Ensure the failure is not due to commits merged from out-of-date branches (i#5873).
For flaky tests, file new issue or update existing one with details.
Please note the action taken in a response on this dynamorio-devs email thread.
Workflow: ${{github.workflow}}/aarchxx-cross-compile
Repository: ${{github.repository}}
Branch ref: ${{github.ref}}
Expand Down
18 changes: 15 additions & 3 deletions .github/workflows/ci-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -103,10 +103,14 @@ jobs:
username: ${{secrets.DYNAMORIO_NOTIFICATION_EMAIL_USERNAME}}
password: ${{secrets.DYNAMORIO_NOTIFICATION_EMAIL_PASSWORD}}
subject: |
[${{github.repository}}] ${{github.workflow}} FAILED
[Author Action Required] [${{github.repository}}] ${{github.workflow}} FAILED
on ${{github.event_name}} at ${{github.ref}}
body: |
Github Actions CI workflow run FAILED!
Commit author must triage and fix the possible regression.
Ensure the failure is not due to commits merged from out-of-date branches (i#5873).
For flaky tests, file new issue or update existing one with details.
Please note the action taken in a response on this dynamorio-devs email thread.
Workflow: ${{github.workflow}}/vs2019-32
Repository: ${{github.repository}}
Branch ref: ${{github.ref}}
Expand Down Expand Up @@ -170,10 +174,14 @@ jobs:
username: ${{secrets.DYNAMORIO_NOTIFICATION_EMAIL_USERNAME}}
password: ${{secrets.DYNAMORIO_NOTIFICATION_EMAIL_PASSWORD}}
subject: |
[${{github.repository}}] ${{github.workflow}} FAILED
[Author Action Required] [${{github.repository}}] ${{github.workflow}} FAILED
on ${{github.event_name}} at ${{github.ref}}
body: |
Github Actions CI workflow run FAILED!
Commit author must triage and fix the possible regression.
Ensure the failure is not due to commits merged from out-of-date branches (i#5873).
For flaky tests, file new issue or update existing one with details.
Please note the action taken in a response on this dynamorio-devs email thread.
Workflow: ${{github.workflow}}/vs2019-64
Repository: ${{github.repository}}
Branch ref: ${{github.ref}}
Expand Down Expand Up @@ -237,10 +245,14 @@ jobs:
username: ${{secrets.DYNAMORIO_NOTIFICATION_EMAIL_USERNAME}}
password: ${{secrets.DYNAMORIO_NOTIFICATION_EMAIL_PASSWORD}}
subject: |
[${{github.repository}}] ${{github.workflow}} FAILED
[Author Action Required] [${{github.repository}}] ${{github.workflow}} FAILED
on ${{github.event_name}} at ${{github.ref}}
body: |
Github Actions CI workflow run FAILED!
Commit author must triage and fix the possible regression.
Ensure the failure is not due to commits merged from out-of-date branches (i#5873).
For flaky tests, file new issue or update existing one with details.
Please note the action taken in a response on this dynamorio-devs email thread.
Workflow: ${{github.workflow}}/vs2019-builds
Repository: ${{github.repository}}
Branch ref: ${{github.ref}}
Expand Down
Loading

0 comments on commit 0685ff9

Please sign in to comment.