Skip to content

Commit

Permalink
DYN-8121 SplashScreen Disable Close Button (#81)
Browse files Browse the repository at this point in the history
* DYN-8121 SplashScreen Disable Close Button

Remove all the code related to Close Button in SplashScreen

* Fixing playwright/test package

Updating the playwright/test package to 1.49.0

* Fixing CodeCoverage report

bumping : zgosalvez/github-actions-report-lcov action to v2 just to see if now it passes.

* Fixing CodeCoverage report github action

bumping : zgosalvez/github-actions-report-lcov action to v3 just to see if now it passes.

* Fixing CodeCoverage report

adding more code for the github action zgosalvez/github-actions-report-lcov@v3

* Fixing CodeCoverage report

removing lcov data

* Revert "Fixing CodeCoverage report"

This reverts commit 5b03d4b.

* Fixing CodeCoverage report

bumping up version

* Fixing CodeCoverage report

- update action versions
- add step to setup lcov

* Bumping up version

bumping up version from 1.0.26 to 1.0.27
  • Loading branch information
RobertGlobant20 authored Jan 27, 2025
1 parent da98f0b commit b73c1a5
Show file tree
Hide file tree
Showing 5 changed files with 57 additions and 73 deletions.
10 changes: 7 additions & 3 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ jobs:
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
uses: actions/setup-node@39370e3970a6d050c480ffad4ff0ed4d3fdee5af # v4.1.0
with:
node-version: ${{ matrix.node-version }}
cache: "npm"
Expand All @@ -34,8 +34,12 @@ jobs:
run: npx playwright install chromium --with-deps
- name: E2E tests
run: npm run test:e2e
- name: Setup LCOV
uses: hrishikesh-kadam/setup-lcov@6c1aa0cc9e1c02f9f58f01ac599f1064ccc83470 # v1.1.0
with:
ref: v1.16
- name: Code Coverage Report
uses: zgosalvez/github-actions-report-lcov@v1
uses: zgosalvez/github-actions-report-lcov@5989987f8058a03137e90bc16f9c0baaac5e069a # v4.1.22
with:
coverage-files: coverage/lcov.info
# minimum-coverage: 50
70 changes: 48 additions & 22 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@dynamods/splash-screen",
"version": "1.0.26",
"version": "1.0.27",
"description": "Splash Screen maintained by Dynamo Team@Autodesk",
"author": "Autodesk Inc.",
"license": "MIT",
Expand Down Expand Up @@ -56,7 +56,7 @@
]
},
"devDependencies": {
"@playwright/test": "^1.27.1",
"@playwright/test": "^1.49.0",
"@testing-library/react": "^13.4.0",
"html-webpack-plugin": "^4.5.2",
"webpack": "^5.74.0",
Expand Down
31 changes: 0 additions & 31 deletions src/App.css
Original file line number Diff line number Diff line change
Expand Up @@ -19,35 +19,4 @@
.screenBackground {
height: 412px;
width: 394px;
}

.close {
position: absolute;
cursor: pointer;
right: 32px;
top: 15px;
width: 16px;
height: 16px;
opacity: 0.3;
}

.close:hover {
opacity: 1;
}

.close:before, .close:after {
position: absolute;
left: 25px;
content: ' ';
height: 16px;
width: 2px;
background-color: #333;
}

.close:before {
transform: rotate(45deg);
}

.close:after {
transform: rotate(-45deg);
}
15 changes: 0 additions & 15 deletions src/App.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ class App extends React.Component {
window.setLoadingDone = this.setLoadingDone.bind(this);
window.setSignInStatus = this.setSignInStatus.bind(this);
this.handleCheckedChange = this.handleCheckedChange.bind(this);
this.closeDynamo = this.closeDynamo.bind(this);
}

handleCheckedChange = (checked) => {
Expand All @@ -45,14 +44,6 @@ class App extends React.Component {
//TODO : As alternative we can receive the event from the Childs like the Static component
}

handleKeyDown = (e) => {
if (e.key === 'Escape') {
if (this.state.loadingDone) {
this.closeDynamo();
}
}
};

render() {
return (
<Container fluid>
Expand Down Expand Up @@ -132,12 +123,6 @@ class App extends React.Component {
loadingDone: true
});
};

closeDynamo() {
if (chrome.webview !== undefined) {
chrome.webview.hostObjects.scriptObject.CloseWindowPreserve(this.state.isChecked);
}
}
}

export default App;

0 comments on commit b73c1a5

Please sign in to comment.