-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update for the Dynamo 3.0 release #50
Changes from 1 commit
0601ecd
d987164
ace1fc8
2735322
289c2af
8ffe71c
be1ceb3
0875f6c
397a25e
d8c00b9
c74dad8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,8 +6,8 @@ | |
<Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration> | ||
<RootNamespace>SampleLibraryTests</RootNamespace> | ||
<AssemblyName>SampleLibraryTests</AssemblyName> | ||
<!--Windows and WPF APIs are needed to support dynamo UI libs--> | ||
<TargetFramework>net8.0-windows</TargetFramework> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think these are worth adding comments for so that sample users don't blindly add these to their repos if they don't need them. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done |
||
<UICulture>en-US</UICulture> | ||
<UseWPF>true</UseWPF> | ||
</PropertyGroup> | ||
<ItemGroup> | ||
|
@@ -16,6 +16,6 @@ | |
</None> | ||
</ItemGroup> | ||
<ItemGroup> | ||
<PackageReference Include="DynamoVisualProgramming.Tests" Version="1.0.0" /> | ||
<PackageReference Include="DynamoVisualProgramming.Tests" Version="0.0.1" /> | ||
</ItemGroup> | ||
</Project> |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,9 +5,12 @@ | |
<PropertyGroup> | ||
<RootNamespace>SampleLibraryUI</RootNamespace> | ||
<AssemblyName>SampleLibraryUI</AssemblyName> | ||
<!--Windows and WPF APIs are needed to support dynamo UI libs--> | ||
<TargetFramework>net8.0-windows</TargetFramework> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
<UseWPF>true</UseWPF> | ||
<UICulture>en-US</UICulture> | ||
<!--EnableDynamicLoading prepares the project so that it can be used as a plugin --> | ||
<!--https://learn.microsoft.com/en-us/dotnet/core/tutorials/creating-app-with-plugin-support#simple-plugin-with-no-dependencies--> | ||
<EnableDynamicLoading>true</EnableDynamicLoading> | ||
<DocumentationFile>bin\$(Configuration)\$(UICulture)\SampleLibraryUI.XML</DocumentationFile> | ||
</PropertyGroup> | ||
<ItemGroup> | ||
|
@@ -21,9 +24,9 @@ | |
<Content Include="images\logo.png" /> | ||
</ItemGroup> | ||
<ItemGroup> | ||
<PackageReference Include="DynamoVisualProgramming.DynamoServices" Version="3.0.0-beta7064" /> | ||
<PackageReference Include="DynamoVisualProgramming.WpfUILibrary" Version="3.0.0-beta7064" /> | ||
<PackageReference Include="DynamoVisualProgramming.ZeroTouchLibrary" Version="3.0.0-beta7064" /> | ||
<PackageReference Include="DynamoVisualProgramming.DynamoServices" Version="3.0.0-beta7064" ExcludeAssets="runtime" /> | ||
<PackageReference Include="DynamoVisualProgramming.WpfUILibrary" Version="3.0.0-beta7064" ExcludeAssets="runtime" /> | ||
<PackageReference Include="DynamoVisualProgramming.ZeroTouchLibrary" Version="3.0.0-beta7064" ExcludeAssets="runtime" /> | ||
</ItemGroup> | ||
<Target Name="AfterBuildOps" AfterTargets="Build"> | ||
<ItemGroup> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because this is a sample and this is a pretty rare property, maybe add a comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done