8150: DYN-8176: Fixes from PythonNet3 #15774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8150
twastvedt
changed the title
github-actions
bot
changed the title
twastvedt
commented
Jan 22, 2025
| @@ -642,7 +641,6 @@ public void VerifySysPathValueForCPythonEngine() | |||
| var pynode = nodeModel as PythonNode; | |||
| UpdatePythonEngineAndRun(pynode, PythonEngineManager.CPython3EngineName); | |||
| sysPathList = GetFlattenedPreviewValues(secondPythonNodeGUID); | |||
| Assert.AreEqual(sysPathList.Count(), 3); | |||
There was a problem hiding this comment.
We now can't be certain of the exact number of paths. But it should be enough (as we are doing) to check that the custom path is visible in the first node and not in the second.
UI Smoke TestsTest: success. 11 passed, 0 failed. |
BogdanZavu
reviewed
Jan 22, 2025
BogdanZavu
approved these changes
Jan 22, 2025
twastvedt
changed the title
github-actions
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Apply a few fixes from PythonNet3 work to CPython3:
pathhandling. Currently we just chop off all but the first three path entries. This PR caches the path before all Python nodes run and uses the cached path for each run. This will fix, for example, the issue wheresite-packagesisn't on the path (If site-packages folder is present the default Python path has 4 items).Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Preserve full original Python path on each Python node run.
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of