DYN-7480 Source-level Localization Pipeline - Node Help Docs #15747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After a several tests I realized that the .resx files with localized strings can be added directly to the project directory location (csproj) level without the need of using Visual Studio. Usually when using Visual Studio for adding resources the <EmbeddedResource> tag is added inside the .csproj file but in this case after testing the localization for other languages was working as expected without using Visual Studio for adding resources. Also the Access Modifier for resx files localized can have the value "No code generation" and the localization in still working.
Extend file_rules to include all *en-US.resx files under src in the repository.
Add file_rules to include DYN Samples files.
QilongTang
changed the title
QilongTang
commented
Jan 8, 2025
| content_owner: N/A | ||
| lang: [csy, deu, esp, fra, ita, jpn, kor, plk, ptb, rus, chs, cht] | ||
| file_rules: | ||
| - doc\distrib\NodeHelpFiles\en-US\*.md, doc\distrib\NodeHelpFiles\%langMsNet%\*.md |
There was a problem hiding this comment.
Only node help docs source level localization turned on for now
QilongTang
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7480
|
|
|
The only change was in ContinuousLocalization.yml? |
UI Smoke TestsTest: success. 11 passed, 0 failed. |
I think so, the changes on md files contribute most of the file changes |
zeusongit
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Enable node help docs source level localization pipeline. This PR includes:
.adskfolder specifying automation from localization teamAfter this PR merged, changes to existing node help docs and addition of new ones will trigger downside pipeline for CL bot to make new PRs to add/update localization, pending Dynamo team to approve.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Enable node help docs source level localization pipeline
Reviewers
@DynamoDS/dynamo
FYIs
@ZbynekHanak-RWS