Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-9999 : add asc install path to system path #15717

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

BogdanZavu
Copy link
Contributor

@BogdanZavu BogdanZavu commented Dec 9, 2024

The ASC path is already added by a major host installer in the system path.
So this change is useful only for internal development ( and similar to what Revit does for package builds ).

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Reviewers

@sm6srw

@BogdanZavu BogdanZavu requested a review from sm6srw December 9, 2024 22:52
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9999

Copy link

github-actions bot commented Dec 9, 2024

UI Smoke Tests

Test: success. 11 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests

Copy link
Contributor

@sm6srw sm6srw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this should also work if the ASC path is overridden.

@QilongTang QilongTang added this to the 3.5 milestone Dec 10, 2024
@BogdanZavu BogdanZavu merged commit 4f85a18 into DynamoDS:master Dec 10, 2024
25 of 29 checks passed
}
catch
{
Trace.WriteLine("Failed to update path for ASC component");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does trace make it to the dynamo log?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, trace does not make it to dynamo log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants