DYN-7927 Prevent Crash from none styled Infobubble #15707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7927
QilongTang
changed the title
QilongTang
changed the title
UI Smoke TestsTest: success. 11 passed, 0 failed. |
pinzart90
reviewed
Dec 6, 2024
| @@ -16,6 +16,7 @@ | |||
| using Dynamo.ViewModels; | |||
| using Dynamo.Wpf.UI; | |||
| using Dynamo.Wpf.Utilities; | |||
| using Microsoft.VisualBasic.Logging; | |||
There was a problem hiding this comment.
probably an intellisense issue. You should not need this
There was a problem hiding this comment.
Thank you @pinzart90 updated
reddyashish
approved these changes
Dec 6, 2024
QilongTang
added a commit
that referenced
this pull request
Dec 6, 2024
9 tasks
QilongTang
added a commit
that referenced
this pull request
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Some convert exception would cause
Convert By Unitsto throw an exception and with no InfoBubble style, Dynamo got a crash from some code 13 years ago. Never happened in my experiences, so I am going to log it instead of throwing.There was no comment about what the value
456B24E0F400means so if anyone has idea, please let me know.Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
N/A
Reviewers
@DynamoDS/dynamo
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of