Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DYN-7840] Placement of UI pop up for input nodes in collapsed group mode is not accurate #15696

Conversation

ivaylo-matov
Copy link
Contributor

Purpose

PR aims to address DYN-7840 where the placement of the UI pop for input ports are off when the group is collapsed.

The code now uses the proxyPorts as PlacementTarget and uses different placement method for them.

DYN-7840-Fix

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Fixed placement of Context menu popup for nodes in collapsed groups.

Reviewers

@reddyashish
@QilongTang

FYIs

@dnenov

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7840

Copy link

github-actions bot commented Dec 3, 2024

UI Smoke Tests

Test: success. 11 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests

@QilongTang QilongTang added this to the 3.5 milestone Dec 3, 2024
@reddyashish
Copy link
Contributor

reddyashish commented Dec 3, 2024

Looks good, Thanks @ivaylo-matov. Just one comment on reusing utility methods.

Dynamo.Tests.PythonEditTests fixture is failing. Doesn't look related.
Running again: https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/16882/

@reddyashish reddyashish merged commit 34aa082 into DynamoDS:master Dec 4, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants