Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude mapping in case the host name is Dynamo #15641

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

zeusongit
Copy link
Contributor

Purpose

After adding Dynamo versions to /host_map, make an exception for Dynamo, and not map it into a Dictionary as it provides a flat list of versions.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

After adding Dynamo versions to /host_map, make an exception for Dynamo, and not map it into a Dictionary as it provides a flat list of versions.

Reviewers

@reddyashish

@zeusongit zeusongit added this to the 3.4 milestone Nov 12, 2024
@zeusongit zeusongit merged commit 9c5d723 into DynamoDS:master Nov 12, 2024
20 of 22 checks passed
zeusongit added a commit to zeusongit/Dynamo that referenced this pull request Nov 12, 2024
Copy link

UI Smoke Tests

Test: success. 11 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants