Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-7392: cherry pick "Update units and adp" in 3.4 #15612

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

pinzart90
Copy link
Contributor

Purpose

Cherry pick ADP and ForgeUnits version update

Per https://jira.autodesk.com/browse/DYN-7392, update dependency originally brought in as part of #12126

Updates ForgeUnits to 5.3.2 as REvit
Updates Forge.Schema to 1.0.4 (latest on public nuget), but it still does not match the latest Revit
Updates Analtics to 4.2.1.6685 which brings in the same version of ADP that Revit uses

(FILL ME IN) This section describes why this PR is here. Usually it would include a reference to the tracking task that it is part or all of the solution for.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Update ADP and ForgeUnits versions to match Revit

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@github-actions github-actions bot changed the title cherry pick "Update units and adp" in 3.4 DYN-7392: cherry pick "Update units and adp" in 3.4 Nov 6, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7392

Copy link

github-actions bot commented Nov 6, 2024

UI Smoke Tests

Test: success. 11 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests

@mjkkirschner
Copy link
Member

do test changes need to come along?

@pinzart90
Copy link
Contributor Author

do test changes need to come along?

I think they are needed for cicd to pass

@pinzart90 pinzart90 merged commit f0baa4e into RC3.4.0_master Nov 7, 2024
25 checks passed
@pinzart90 pinzart90 deleted the update_units_and_adp branch November 7, 2024 02:10
@QilongTang QilongTang added this to the 3.4 milestone Nov 12, 2024
@QilongTang
Copy link
Contributor

Thank you @pinzart90 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants