Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LIBG 229 in 2.19.5 #15029

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

sm6srw
Copy link
Contributor

@sm6srw sm6srw commented Mar 19, 2024

Purpose

This will cherry-pick DYN-6043

All tests passed on master-15.

This will add two new files for the geometry primitives.

I have not seen any side effects but let me know if you think that we should skip this because it can have some unforeseen consequences.

Declarations

Just a test for now.

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

(FILL ME IN) Brief description of the fix / enhancement. Mandatory section

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@sm6srw sm6srw changed the title WIP: Update asm229 in 2.19.5 WIP: Update LIBG 229 in 2.19.5 Mar 19, 2024
@mjkkirschner
Copy link
Member

@sm6srw seems like a lot of unintended changes in this PR.

@sm6srw sm6srw changed the base branch from master to RC2.19.5_master March 19, 2024 15:28
@sm6srw
Copy link
Contributor Author

sm6srw commented Mar 19, 2024

Oops, wrong base. Sorry.

@aparajit-pratap
Copy link
Contributor

So this version of libg contains geometryprimitives as well?

@sm6srw
Copy link
Contributor Author

sm6srw commented Mar 19, 2024

So this version of libg contains geometryprimitives as well?

Yes, one of the complications.

@sm6srw sm6srw changed the title WIP: Update LIBG 229 in 2.19.5 Update LIBG 229 in 2.19.5 Mar 20, 2024
Copy link
Contributor

@aparajit-pratap aparajit-pratap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sm6srw did you do some manual testing on the offset issue in Dynamo with this version of libg?

@sm6srw
Copy link
Contributor Author

sm6srw commented Mar 20, 2024

@sm6srw did you do some manual testing on the offset issue in Dynamo with this version of libg?

Yes, I did.

@sm6srw sm6srw merged commit a046742 into DynamoDS:RC2.19.5_master Mar 21, 2024
21 of 23 checks passed
@sm6srw sm6srw deleted the update_asm229_in_2.19.5 branch March 21, 2024 01:10
@QilongTang QilongTang added this to the 2.19.5 milestone Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants