Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-6664: Fix crash when no asm is found. #14958

Merged
merged 2 commits into from
Feb 22, 2024
Merged

DYN-6664: Fix crash when no asm is found. #14958

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
599b631
Fix crash when no asm is found.
sm6srw Feb 20, 2024
0e5661d
Merge branch 'master' of https://github.com/DynamoDS/Dynamo into fix-…
sm6srw Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/NodeServices/WorkspaceEvents.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,13 @@ internal static void OnWorkspaceSettingsChanged(bool enableLegacyPolyCurveBehavi
var handler = WorkspaceEnableLegacyPolyCurveSettingChanged;
if (handler != null)
{
handler(new WorkspacesSettingsChangedEventArgs(enableLegacyPolyCurveBehavior));
try
{
handler(new WorkspacesSettingsChangedEventArgs(enableLegacyPolyCurveBehavior));
}
catch (NullReferenceException)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is null in this case?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it hard to add a test for this? I would not have expected this to need a try catch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something inside LibG because ASM is missing. I think this fix is the best one for 3.0.4 as I don't think we want to add paneling in 3.0.4. That being said, for master, I could go ahead and fix this in LibG and then remove this try/catch when the new LibG version with that fix is integrated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think mGeometryFactory is null in this line when ASM is not found.

{
}
}
}
}
Expand Down
Loading