DYN-5656-PackagesGuide-BugFix #14849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When opening the Packages tour and later opening the PackageManager (during the tour) at closing was removing the wrong dark background, then I added some code for searching for the specific overlay added (not the one added by the guided tour). Also deleted the code for using the EnableEnvironment function due that is not used any more.
QilongTang
approved these changes
Jan 16, 2024
|
GIF showing the behavior when opening Preferences panel, Package Manager and Packages guide. |
UI Smoke TestsTest: success. 2 passed, 0 failed. |
zeusongit
pushed a commit
to zeusongit/Dynamo
that referenced
this pull request
Jan 17, 2024
When opening the Packages tour and later opening the PackageManager (during the tour) at closing was removing the wrong dark background, then I added some code for searching for the specific overlay added (not the one added by the guided tour). Also deleted the code for using the EnableEnvironment function due that is not used any more.
zeusongit
added a commit
that referenced
this pull request
Jan 17, 2024
* Fix PostDiff job * Update ShortcutToolbar.xaml.cs * update * Update ShortcutToolbar.xaml * DYN-5656-PackagesGuide-BugFix (#14849) When opening the Packages tour and later opening the PackageManager (during the tour) at closing was removing the wrong dark background, then I added some code for searching for the specific overlay added (not the one added by the guided tour). Also deleted the code for using the EnableEnvironment function due that is not used any more. --------- Co-authored-by: Roberto T <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixing bug when showing/hiding the dark overlay
When opening the Packages tour and later opening the PackageManager (during the tour) at closing was removing the wrong dark background, then I added some code for searching for the specific overlay added (not the one added by the guided tour). Also deleted the code for using the EnableEnvironment function due that is not used any more.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Fixing bug when showing/hiding the dark overlay
Reviewers
@QilongTang
FYIs
@avidit